Fixed
Pinned fields
Click on the next to a field label to start pinning.
Details
Assignee
isaac.lambatisaac.lambatReporter
Ben BrooksBen BrooksStory Points
2Components
Sprint
NoneFix versions
Priority
MajorInstabug
Open Instabug
Details
Details
Assignee
isaac.lambat
isaac.lambatReporter
Ben Brooks
Ben BrooksStory Points
2
Components
Sprint
None
Fix versions
Priority
Instabug
Open Instabug
PagerDuty
PagerDuty
PagerDuty
Sentry
Sentry
Sentry
Zendesk Support
Zendesk Support
Zendesk Support
Created October 20, 2021 at 7:35 PM
Updated November 9, 2021 at 5:43 PM
Resolved October 28, 2021 at 1:58 PM
The
validateLogFilePath()
function does not check if the configuredlogFilePath
directory is writable, as it correctly assumes Lumberjack (the underlying logger) errors for a non-writable log file, but this is only done lazily on the first call tolumberjack.Logger.Write()
, which is then subsequently ignored bylog.Logger.Printf
... not at the time of initialization.Include an upfront permission check that can cause SG to fail to start if the configured log file path is not writable. This isn't perfect if somebody changes the permissions between the initial check and the subsequent logging, but we could also change
logf()
to calll.Output
instead ofl.Printf
in order to get the write-time error.