Improve error when non-upgradable HTTP request is sent to _blipsync endpoint

Description

When a non-upgradable plain HTTP request is sent to /_blipsync, a request panic occurs, and it's not exactly clear to the user what the reason is.

An easy way to trigger this, is to visit the /_blipsync endpoint via a web browser. But the issue can also be seen via CBL 2.x if connecting through a non-websocket compatible proxy.

 

This is inherent to the Go websocket implementation, but it can be caught earlier in handleBlipsync in order to respond with a more sensible status code and error message.

https://github.com/couchbase/sync_gateway/issues/4651

Activity

Show:

CB robot July 29, 2020 at 8:53 PM

Build sync_gateway-2.8.0-286 contains sync_gateway commit 6132c1e with commit message:
: Improve error when non-upgradable HTTP request is sent to _b… (#4690)

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Story Points

Components

Sprint

Fix versions

Priority

Instabug

Open Instabug

PagerDuty

Sentry

Zendesk Support

Created July 6, 2020 at 12:52 PM
Updated August 4, 2020 at 5:42 PM
Resolved July 29, 2020 at 9:04 PM
Instabug