Uploaded image for project: 'Couchbase ASP.NET Integration'
  1. Couchbase ASP.NET Integration
  2. CBASP-14

AspNet not throwing error when comment says it should

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Won't Fix
    • 2.0.0-beta2
    • 2.0.0-beta3
    • None

    Description

      In CouchbaseSessionStateProvider.cs / SessionStateItem / Save, the code states:

      // Attempt to save the data and fail if the CAS fails

      But, it does not check the response to ensure it was successful. I don't know if failing a request on a failed save of data should be this, but you can assess.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          jmorris Jeff Morris added a comment -

          I don't think this is wrong; the calling method will loop and continue to call SaveData until the CAS condition is satisfied.

          jmorris Jeff Morris added a comment - I don't think this is wrong; the calling method will loop and continue to call SaveData until the CAS condition is satisfied.

          People

            jmorris Jeff Morris
            unhuman unhuman
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty