Uploaded image for project: 'Couchbase Gateway'
  1. Couchbase Gateway
  2. CBG-1172

ISGR credentials with characters requiring URL encoding cause blipsync to fail

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 2.8.0
    • 3.0
    • SyncGateway
    • Security Level: Public
    • None
    • CBG Sprint 61
    • 2

    Description

      Credentials for ISG replications are incorrectly escaped with URL encoding before being base64 encoded when building the Authorization header for the _blipsync endpoint.

      This results in websockets failing to connect if usernames or passwords contain a lot of special characters due to the reason: "bad status", even though the prior HTTP request succeeded (the initial HTTP request is using basic auth, and so escaping there is a valid thing to do).

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            Build sync_gateway-3.0.0-38 contains sync_gateway commit 6019351 with commit message:
            CBG-1172 - Fix incorrect URL encoding of credentials when using Authorization header (#4836)

            build-team Couchbase Build Team added a comment - Build sync_gateway-3.0.0-38 contains sync_gateway commit 6019351 with commit message: CBG-1172 - Fix incorrect URL encoding of credentials when using Authorization header (#4836)

            Build sync_gateway-2.8.0.1-2 contains sync_gateway commit c2431b2 with commit message:
            CBG-1172 - Fix incorrect URL encoding of credentials when using Authorization header (#4836) (#4839)

            build-team Couchbase Build Team added a comment - Build sync_gateway-2.8.0.1-2 contains sync_gateway commit c2431b2 with commit message: CBG-1172 - Fix incorrect URL encoding of credentials when using Authorization header (#4836) (#4839)

            People

              ben.brooks Ben Brooks
              ben.brooks Ben Brooks
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty