Uploaded image for project: 'Couchbase Gateway'
  1. Couchbase Gateway
  2. CBG-1424

discoverInterfaceName should resolve hostnames before trying to find network interface stats using IP addresses

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • None
    • 3.0
    • SyncGateway
    • Security Level: Public
    • None
    • CBG Sprint 74
    • 3

    Description

      The code to find a matching network interface to pull stats for assumes the configured interaface is an IP address, but it's just as valid (if not more) to specify a hostname instead.

      When the interface is a hostname, discoverInterfaceName() fails to find a matching address from the list of system network interfaces, because it's still trying to match against a hostname instead of an address.

      It would be handy if Sync Gateway performed a lookup to fetch IP addresses for a hostname if an IP address was not specified in the first place, before falling through to the existing code. This ensures machines that are able to resolve an address can accurately map it back to a given network interface.

       

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            Build sync_gateway-3.0.0-198 contains sync_gateway commit 58dd304 with commit message:
            CBG-1424 - Show network interface stats when configured API listen adresses use hostnames instead of IPs (#5001)

            build-team Couchbase Build Team added a comment - Build sync_gateway-3.0.0-198 contains sync_gateway commit 58dd304 with commit message: CBG-1424 - Show network interface stats when configured API listen adresses use hostnames instead of IPs (#5001)

            Build sync_gateway-2.8.3-4 contains sync_gateway commit 10ef540 with commit message:
            [2.8.3] CBG-1444: Backport CBG-1424: Show network interface stats when configured API listen adresses use hostnames instead of IPs (#5001) (#5268)

            build-team Couchbase Build Team added a comment - Build sync_gateway-2.8.3-4 contains sync_gateway commit 10ef540 with commit message: [2.8.3] CBG-1444 : Backport CBG-1424 : Show network interface stats when configured API listen adresses use hostnames instead of IPs (#5001) (#5268)

            People

              ben.brooks Ben Brooks
              ben.brooks Ben Brooks
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty