Uploaded image for project: 'Couchbase Gateway'
  1. Couchbase Gateway
  2. CBG-279

go-blip leaks nextFrameToSend goroutine under aborted multi-frame send

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.3
    • Fix Version/s: 2.6.0
    • Component/s: SyncGateway
    • Security Level: Public
    • Labels:
      None
    • Sprint:
      CBG Sprint 18, CBG Sprint 19
    • Story Points:
      5

      Description

      When aborting sending a message over BLIP, and that message is large enough to span multiple frames, nextFrameToSend leaks its encoder writer goroutine and it never unblocks on m.WriteTo()

      This can be seen in the expvars, as goblip.goroutines_next_frame_to_send:93, and observed in the goroutine profiles.

        Attachments

          Issue Links

          backports to

          Task - A task that needs to be done. CBG-300 Backport CBG-279 to 2.1.4, 2.5.1 (go-blip leaks nextFrameToSend goroutine under aborted multi-frame send)

          • Major - Major loss of function.
          • Resolved

          Task - A task that needs to be done. CBG-312 Backport CBG-279 to 2.5.0

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            build-team Couchbase Build Team added a comment -

            Build sync_gateway-2.1.3.1-2 contains go-blip commit 0d0c6a8 with commit message:
            CBG-279 Fix leak in nextFrameToSend by closing message encoder (#38) (#41)

            Show
            build-team Couchbase Build Team added a comment - Build sync_gateway-2.1.3.1-2 contains go-blip commit 0d0c6a8 with commit message: CBG-279 Fix leak in nextFrameToSend by closing message encoder (#38) (#41)
            Hide
            Permalink
            build-team Couchbase Build Team added a comment -

            Build sync_gateway-2.1.3.1-2 contains go-blip commit 0d0c6a8 with commit message:
            CBG-279 Fix leak in nextFrameToSend by closing message encoder (#38) (#41)

            Show
            build-team Couchbase Build Team added a comment - Build sync_gateway-2.1.3.1-2 contains go-blip commit 0d0c6a8 with commit message: CBG-279 Fix leak in nextFrameToSend by closing message encoder (#38) (#41)
            Hide
            Permalink
            build-team Couchbase Build Team added a comment -

            Build sync_gateway-2.5.1-2 contains sync_gateway commit 2ec2a41 with commit message:
            CBG-300 - Backport CBG-279 (#4052)

            Show
            build-team Couchbase Build Team added a comment - Build sync_gateway-2.5.1-2 contains sync_gateway commit 2ec2a41 with commit message: CBG-300 - Backport CBG-279 (#4052)
            Hide
            Permalink
            build-team Couchbase Build Team added a comment -

            Build sync_gateway-2.5.0-270 contains go-blip commit e3991ef with commit message:
            CBG-279 Fix leak in nextFrameToSend by closing message encoder (#38)

            Show
            build-team Couchbase Build Team added a comment - Build sync_gateway-2.5.0-270 contains go-blip commit e3991ef with commit message: CBG-279 Fix leak in nextFrameToSend by closing message encoder (#38)
            Hide
            Permalink
            build-team Couchbase Build Team added a comment -

            Build sync_gateway-2.5.0-270 contains go-blip commit e3991ef with commit message:
            CBG-279 Fix leak in nextFrameToSend by closing message encoder (#38)

            Show
            build-team Couchbase Build Team added a comment - Build sync_gateway-2.5.0-270 contains go-blip commit e3991ef with commit message: CBG-279 Fix leak in nextFrameToSend by closing message encoder (#38)
            Hide
            Permalink
            build-team Couchbase Build Team added a comment -

            Build sync_gateway-2.6.0-11 contains go-blip commit e3991ef with commit message:
            CBG-279 Fix leak in nextFrameToSend by closing message encoder (#38)

            Show
            build-team Couchbase Build Team added a comment - Build sync_gateway-2.6.0-11 contains go-blip commit e3991ef with commit message: CBG-279 Fix leak in nextFrameToSend by closing message encoder (#38)
            Hide
            Permalink
            build-team Couchbase Build Team added a comment -

            Build sync_gateway-2.6.0-11 contains go-blip commit e3991ef with commit message:
            CBG-279 Fix leak in nextFrameToSend by closing message encoder (#38)

            Show
            build-team Couchbase Build Team added a comment - Build sync_gateway-2.6.0-11 contains go-blip commit e3991ef with commit message: CBG-279 Fix leak in nextFrameToSend by closing message encoder (#38)
            Hide
            Permalink
            build-team Couchbase Build Team added a comment -

            Build sync_gateway-2.6.0-11 contains sync_gateway commit 20d9210 with commit message:
            CBG-279 - Bump go-blip manifest to uptake latest master version (#4076)

            Show
            build-team Couchbase Build Team added a comment - Build sync_gateway-2.6.0-11 contains sync_gateway commit 20d9210 with commit message: CBG-279 - Bump go-blip manifest to uptake latest master version (#4076)

              People

              Assignee:
              ben.brooks Ben Brooks
              Reporter:
              ben.brooks Ben Brooks
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes

                    PagerDuty