Uploaded image for project: 'Couchbase Gateway'
  1. Couchbase Gateway
  2. CBG-309

Don't log expected REST errors to sg_error.log

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.0
    • Fix Version/s: 2.6.0
    • Component/s: SyncGateway
    • Security Level: Public
    • Labels:
      None
    • Sprint:
      CBG Sprint 20
    • Story Points:
      3

      Description

      The changes in https://github.com/couchbase/sync_gateway/pull/3593 incorrectly added ERR level logging for expected REST API errors (key not found on GET, etc).

      Error logging should be reserved for critical errors that require user attention.  

      In handler.go, h.writeError should be modified to only log the error if status is greater than or equal to 500.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          Hide
          build-team Couchbase Build Team added a comment -

          Build sync_gateway-2.6.0-23 contains sync_gateway commit 19963cf with commit message:
          CBG-309 - Only log errors returned from HTTP handlers for status >= 500 (#4086)

          Show
          build-team Couchbase Build Team added a comment - Build sync_gateway-2.6.0-23 contains sync_gateway commit 19963cf with commit message: CBG-309 - Only log errors returned from HTTP handlers for status >= 500 (#4086)
          Hide
          build-team Couchbase Build Team added a comment -

          Build sync_gateway-2.6.0-23 contains sync_gateway commit 19963cf with commit message:
          CBG-309 - Only log errors returned from HTTP handlers for status >= 500 (#4086)

          Show
          build-team Couchbase Build Team added a comment - Build sync_gateway-2.6.0-23 contains sync_gateway commit 19963cf with commit message: CBG-309 - Only log errors returned from HTTP handlers for status >= 500 (#4086)

            People

            Assignee:
            ben.brooks Ben Brooks
            Reporter:
            adamf Adam Fraser
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes

                  PagerDuty