Uploaded image for project: 'Couchbase Gateway'
  1. Couchbase Gateway
  2. CBG-949

Improve error when non-upgradable HTTP request is sent to _blipsync endpoint

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • None
    • 3.0
    • SyncGateway
    • Security Level: Public
    • None
    • CBG Sprint 54
    • 2

    Description

      When a non-upgradable plain HTTP request is sent to /_blipsync, a request panic occurs, and it's not exactly clear to the user what the reason is.

      An easy way to trigger this, is to visit the /_blipsync endpoint via a web browser. But the issue can also be seen via CBL 2.x if connecting through a non-websocket compatible proxy.

       

      This is inherent to the Go websocket implementation, but it can be caught earlier in handleBlipsync in order to respond with a more sensible status code and error message.

      https://github.com/couchbase/sync_gateway/issues/4651

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          ben.brooks Ben Brooks created issue -
          ben.brooks Ben Brooks made changes -
          Field Original Value New Value
          Description When a non-upgradable plain HTTP request is sent to /_blipsync, a request panic occurs, and it's not exactly clear to the user what the reason is.

          An easy way to trigger this, is to visit the /_blipsync endpoint via a web browser. But the issue can also be seen via CBL 2.x if connecting through a non-websocket compatible proxy.

           

          This is inherent to the Go websocket implementation, but it can be caught earlier in _blipsync in order to respond with a more sensible status code and error message.

          [https://github.com/couchbase/sync_gateway/issues/4651]
          When a non-upgradable plain HTTP request is sent to /_blipsync, a request panic occurs, and it's not exactly clear to the user what the reason is.

          An easy way to trigger this, is to visit the /_blipsync endpoint via a web browser. But the issue can also be seen via CBL 2.x if connecting through a non-websocket compatible proxy.

           

          This is inherent to the Go websocket implementation, but it can be caught earlier in handleBlipsync in order to respond with a more sensible status code and error message.

          [https://github.com/couchbase/sync_gateway/issues/4651]
          adamf Adam Fraser made changes -
          Fix Version/s Hydrogen [ 16179 ]
          adamf Adam Fraser made changes -
          Story Points 2
          daniel.petersen Daniel Petersen made changes -
          Fix Version/s Lithium [ 16180 ]
          Fix Version/s Hydrogen [ 16179 ]
          Priority Minor [ 4 ] Critical [ 2 ]
          adamf Adam Fraser made changes -
          Assignee The One [ the one ] Sarath Kumar Sivan [ sarath.kumarsivan ]
          adamf Adam Fraser made changes -
          Sprint CBG Sprint 54 [ 1173 ]
          adamf Adam Fraser made changes -
          Rank Ranked lower
          sarath.kumarsivan Sarath Kumar Sivan (Inactive) made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Automated transition triggered when Sarath Kumar Sivan created pull request #4690 in GitHub -
          Status In Progress [ 3 ] In Review [ 10107 ]

          Build sync_gateway-2.8.0-286 contains sync_gateway commit 6132c1e with commit message:
          CBG-949: Improve error when non-upgradable HTTP request is sent to _b… (#4690)

          build-team Couchbase Build Team added a comment - Build sync_gateway-2.8.0-286 contains sync_gateway commit 6132c1e with commit message: CBG-949 : Improve error when non-upgradable HTTP request is sent to _b… (#4690)
          Automated transition triggered when Adam Fraser merged pull request #4690 in GitHub -
          Resolution Fixed [ 1 ]
          Status In Review [ 10107 ] Resolved [ 5 ]
          sarath.kumarsivan Sarath Kumar Sivan (Inactive) made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

          People

            sarath.kumarsivan Sarath Kumar Sivan (Inactive)
            ben.brooks Ben Brooks
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty