Details
-
Improvement
-
Status: Closed
-
Critical
-
Resolution: Fixed
-
None
-
Security Level: Public
-
None
-
CBG Sprint 54
-
2
Description
When a non-upgradable plain HTTP request is sent to /_blipsync, a request panic occurs, and it's not exactly clear to the user what the reason is.
An easy way to trigger this, is to visit the /_blipsync endpoint via a web browser. But the issue can also be seen via CBL 2.x if connecting through a non-websocket compatible proxy.
This is inherent to the Go websocket implementation, but it can be caught earlier in handleBlipsync in order to respond with a more sensible status code and error message.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
When a non-upgradable plain HTTP request is sent to /_blipsync, a request panic occurs, and it's not exactly clear to the user what the reason is.
An easy way to trigger this, is to visit the /_blipsync endpoint via a web browser. But the issue can also be seen via CBL 2.x if connecting through a non-websocket compatible proxy. This is inherent to the Go websocket implementation, but it can be caught earlier in _blipsync in order to respond with a more sensible status code and error message. [https://github.com/couchbase/sync_gateway/issues/4651] |
When a non-upgradable plain HTTP request is sent to /_blipsync, a request panic occurs, and it's not exactly clear to the user what the reason is.
An easy way to trigger this, is to visit the /_blipsync endpoint via a web browser. But the issue can also be seen via CBL 2.x if connecting through a non-websocket compatible proxy. This is inherent to the Go websocket implementation, but it can be caught earlier in handleBlipsync in order to respond with a more sensible status code and error message. [https://github.com/couchbase/sync_gateway/issues/4651] |
| Fix Version/s | Hydrogen [ 16179 ] |
| Story Points | 2 |
| Fix Version/s | Lithium [ 16180 ] | |
| Fix Version/s | Hydrogen [ 16179 ] | |
| Priority | Minor [ 4 ] | Critical [ 2 ] |
| Assignee | The One [ the one ] | Sarath Kumar Sivan [ sarath.kumarsivan ] |
| Sprint | CBG Sprint 54 [ 1173 ] |
| Rank | Ranked lower |
| Status | Open [ 1 ] | In Progress [ 3 ] |
Automated transition triggered when Sarath Kumar Sivan created pull request #4690 in GitHub -
| Status | In Progress [ 3 ] | In Review [ 10107 ] |
Automated transition triggered when Adam Fraser merged pull request #4690 in GitHub -
| Resolution | Fixed [ 1 ] | |
| Status | In Review [ 10107 ] | Resolved [ 5 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |