Uploaded image for project: 'Couchbase Lite'
  1. Couchbase Lite
  2. CBL-1908

Add cookie using setValue instead of addValue

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.8.0
    • 3.0
    • iOS
    • Security Level: Public
    • None
    • Jay 47
    • 2

    Description

      When using the 'addValue:forHTTPHeaderField', it incrementally appends the key-value using a comma.

      Multiple message-header fields with the same field-name MAY be present in a message if and only if the entire field-value for that header field is defined as a comma-separated list
      // https://tools.ietf.org/html/rfc2616#page-32

      May be we should use 'setValue: forHTTPHeaderField', which avoids the issue of cookies with comma delimiter, instead semi-colon delimiter.

      Related GH issue: https://github.com/couchbase/couchbase-lite-ios/issues/2828

      Validate fix using proxy app?

      Attachments

        Issue Links

          is cloned by

          Bug - A problem which impairs or prevents the functions of the product. CBL-2184 [Backport] Add cookie using setValue instead of addValue

          • Major - Major loss of function.
          • Closed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            Ascending order - Click to sort in descending order
            Jayahari.Vavachan Jay Vavachan created issue -
            Jayahari.Vavachan Jay Vavachan made changes -
            Field Original Value New Value
            Rank Ranked higher
            Jayahari.Vavachan Jay Vavachan made changes -
            Assignee The Lite [ cbgto ] Jayahari Vavachan [ jayahari.vavachan ]
            Jayahari.Vavachan Jay Vavachan made changes -
            Story Points 3 2
            daniel.petersen Daniel Petersen made changes -
            Sprint Pasin 47 [ 1597 ]
            daniel.petersen Daniel Petersen made changes -
            Rank Ranked lower
            Jayahari.Vavachan Jay Vavachan made changes -
            Rank Ranked higher
            Jayahari.Vavachan Jay Vavachan made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Jayahari.Vavachan Jay Vavachan made changes -
            Status In Progress [ 3 ] In Review [ 10107 ]
            Jayahari.Vavachan Jay Vavachan made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10107 ] Resolved [ 5 ]
            Jayahari.Vavachan Jay Vavachan made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            callum.majumdar Callum Majumdar made changes -
            Link This issue causes CBSE-10389 [ CBSE-10389 ]
            daniel.petersen Daniel Petersen made changes -
            Link This issue relates to CBL-2183 [ CBL-2183 ]
            daniel.petersen Daniel Petersen made changes -
            Link This issue relates to CBL-2183 [ CBL-2183 ]
            daniel.petersen Daniel Petersen made changes -
            Link This issue is cloned by CBL-2184 [ CBL-2184 ]
            Jayahari.Vavachan Jay Vavachan added a comment -

            For easy tracking listing the fix:
            PR: https://github.com/couchbase/couchbase-lite-ios/pull/2841

            master: https://github.com/couchbase/couchbase-lite-ios/commit/02af6e22c800806f05125f5d54210e1a5dc2fb80
            hydrogen/release: https://github.com/couchbase/couchbase-lite-ios/commit/de889b0a8ba4c642242186459f0a7c80977def0c

            Jayahari.Vavachan Jay Vavachan added a comment - For easy tracking listing the fix: PR: https://github.com/couchbase/couchbase-lite-ios/pull/2841 master: https://github.com/couchbase/couchbase-lite-ios/commit/02af6e22c800806f05125f5d54210e1a5dc2fb80 hydrogen/release: https://github.com/couchbase/couchbase-lite-ios/commit/de889b0a8ba4c642242186459f0a7c80977def0c
            Jayahari.Vavachan Jay Vavachan made changes -
            Resolution Fixed [ 1 ]
            Status Closed [ 6 ] Reopened [ 4 ]
            Jayahari.Vavachan Jay Vavachan made changes -
            Affects Version/s 2.8.0 [ 16189 ]
            Affects Version/s Lithium [ 16190 ]
            Jayahari.Vavachan Jay Vavachan made changes -
            Resolution Fixed [ 1 ]
            Status Reopened [ 4 ] Resolved [ 5 ]
            Jayahari.Vavachan Jay Vavachan made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            daniel.petersen Daniel Petersen made changes -
            Link This issue causes CBSE-10813 [ CBSE-10813 ]

            People

              Jayahari.Vavachan Jay Vavachan
              Jayahari.Vavachan Jay Vavachan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty