Uploaded image for project: 'Couchbase Lite'
  1. Couchbase Lite
  2. CBL-437

Deprecated Database.setLogLevel is not logging

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 2.7.0
    • iOS
    • Security Level: Public
    • None
    • CBL Sprint 5
    • 2

    Description

      Seems like deprecated database set log level is not doing anything other than printing a warning message.

      iOS code

      Android code, hoping this works

      .NET code

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            blake.meike Blake Meike added a comment -

            Interestingly, this is deprecated in Android too... There is even a comment that says that it does nothing. The code, however, actually does do something, just not very will. I just got through fixing it...

            blake.meike Blake Meike added a comment - Interestingly, this is deprecated in Android too... There is even a comment that says that it does nothing. The code, however, actually does do something, just not very will. I just got through fixing it...

            Deprecated should still work. It just means we can remove the API in some future release, so I hope the fix was making the code do the right thing and not nothing.

            daniel.petersen Daniel Petersen added a comment - Deprecated should still work. It just means we can remove the API in some future release, so I hope the fix was making the code do the right thing and not nothing.
            blake.meike Blake Meike added a comment -

            Yeah.... It does something plausible, now. It interacts in a very weird way, with the other logging controls we have. ... but it works.

            blake.meike Blake Meike added a comment - Yeah.... It does something plausible, now. It interacts in a very weird way, with the other logging controls we have. ... but it works.
            jimb Jim Borden added a comment -

            I remember having a discussion about this in which we agreed that while not ideal, this method should be a no-op.  In C# this is both a compiler warning and a runtime logging message.  There is no way for us to get it to function 100% like it did before in C# because this also controlled the file logging level (something the other platforms didn't have at the time), and the new file logging API does not use domains. 

            jimb Jim Borden added a comment - I remember having a discussion about this in which we agreed that while not ideal, this method should be a no-op.  In C# this is both a compiler warning and a runtime logging message.  There is no way for us to get it to function 100% like it did before in C# because this also controlled the file logging level (something the other platforms didn't have at the time), and the new file logging API does not use domains. 
            blake.meike Blake Meike added a comment -

            I like that suggestion. I doubt, very seriously, that any of our users will be able to use this function to do anything expected and useful.

            blake.meike Blake Meike added a comment - I like that suggestion. I doubt, very seriously, that any of our users will be able to use this function to do anything expected and useful.

            Build couchbase-lite-ios-2.7.0-60 contains couchbase-lite-ios commit 89d3654 with commit message:
            CBL-437: fix: deprecated setlog level method (#2555)

            build-team Couchbase Build Team added a comment - Build couchbase-lite-ios-2.7.0-60 contains couchbase-lite-ios commit 89d3654 with commit message: CBL-437 : fix: deprecated setlog level method (#2555)

            People

              Jayahari.Vavachan Jay Vavachan
              Jayahari.Vavachan Jay Vavachan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty