Uploaded image for project: 'Couchbase C client library libcouchbase'
  1. Couchbase C client library libcouchbase
  2. CCBC-107

Handle stale/already sent pending commands on network error

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.0beta
    • Fix Version/s: 2.0.0beta3
    • Component/s: None
    • Security Level: Public
    • Labels:
      None
    No reviews matched the request. Check your Options in the drop-down menu of this sections header.

      Activity

      mnunberg Mark Nunberg created issue -
      avsej Sergey Avseyev made changes -
      Field Original Value New Value
      Fix Version/s 2.0.0beta3 [ 10415 ]
      Fix Version/s 2.0.0 [ 10395 ]
      Hide
      avsej Sergey Avseyev added a comment -

      what is stale command? libcouchbase doesn't have timeout per each command, so if server required to respond, but doesn't do it – it is server bug. from other hand, if socket looks like dead, we are using timeout to purge requests

      Show
      avsej Sergey Avseyev added a comment - what is stale command? libcouchbase doesn't have timeout per each command, so if server required to respond, but doesn't do it – it is server bug. from other hand, if socket looks like dead, we are using timeout to purge requests
      avsej Sergey Avseyev made changes -
      Assignee Sergey Avseyev [ avsej ] Matt Ingenthron [ ingenthr ]
      Hide
      ingenthr Matt Ingenthron added a comment -

      Mark: Do you believe this needs to be addressed before 2.0 GA? If so, please drop in a note with the details.

      My current read on this is that it's not really needed.

      Show
      ingenthr Matt Ingenthron added a comment - Mark: Do you believe this needs to be addressed before 2.0 GA? If so, please drop in a note with the details. My current read on this is that it's not really needed.
      ingenthr Matt Ingenthron made changes -
      Priority Major [ 3 ] Blocker [ 1 ]
      Hide
      avsej Sergey Avseyev added a comment -
      Show
      avsej Sergey Avseyev added a comment - Putting explicit link to test case http://review.couchbase.org/#/c/13667/12/tests/smoke-test.c
      Hide
      ingenthr Matt Ingenthron added a comment -

      Sergey: please extract the test in the referenced patchset and get it correct. Then, please update this issue with any findings from running that test. We'll see from there whether or not to keep it as a blocker.

      I do agree that if operations timeout, that's okay when the connection is interrupted.

      Show
      ingenthr Matt Ingenthron added a comment - Sergey: please extract the test in the referenced patchset and get it correct. Then, please update this issue with any findings from running that test. We'll see from there whether or not to keep it as a blocker. I do agree that if operations timeout, that's okay when the connection is interrupted.
      ingenthr Matt Ingenthron made changes -
      Assignee Matt Ingenthron [ ingenthr ] Sergey Avseyev [ avsej ]
      Hide
      avsej Sergey Avseyev added a comment -

      The test has been ported to recent libcouchbase http://review.couchbase.org/22585 and currently it is passing

      Show
      avsej Sergey Avseyev added a comment - The test has been ported to recent libcouchbase http://review.couchbase.org/22585 and currently it is passing
      Hide
      avsej Sergey Avseyev added a comment -

      Resolving the ticket, because the unit test from that patch is passing on recent version

      Show
      avsej Sergey Avseyev added a comment - Resolving the ticket, because the unit test from that patch is passing on recent version
      avsej Sergey Avseyev made changes -
      Status Open [ 1 ] Resolved [ 5 ]
      Assignee Sergey Avseyev [ avsej ] Mark Nunberg [ mnunberg ]
      Resolution Fixed [ 1 ]
      avsej Sergey Avseyev made changes -
      Status Resolved [ 5 ] Closed [ 6 ]
      brett19 Brett Lawson made changes -
      Workflow jira [ 21092 ] Couchbase SDK Workflow [ 43774 ]

        People

        • Assignee:
          mnunberg Mark Nunberg
          Reporter:
          mnunberg Mark Nunberg
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Gerrit Reviews

            There are no open Gerrit changes