Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.0.0beta2
    • Fix Version/s: None
    • Component/s: None
    • Security Level: Public
    • Labels:
      None

      Description

      I created a NMakefile and made changes to the code to support libevent on windows.

      Files affected:
      iofactory.c
      plugin-libevent.c

      New file:
      NMakefile.libevent

      I uploaded a zipfile of the changes if you are interested in merging them.

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Hide
        avsej Sergey Avseyev added a comment -

        it would be awesome if you can move your patch to our review system. http://review.couchbase.com

        Show
        avsej Sergey Avseyev added a comment - it would be awesome if you can move your patch to our review system. http://review.couchbase.com
        Hide
        brettharrison Brett Harrison added a comment -

        Is there a guild on how to use the review system? If you can explain the steps I'll upload the patch.

        Show
        brettharrison Brett Harrison added a comment - Is there a guild on how to use the review system? If you can explain the steps I'll upload the patch.
        Hide
        ingenthr Matt Ingenthron added a comment -

        It's roughly http://www.couchbase.com/wiki/display/couchbase/Contributing+Changes

        Repo tool isn't required for this project though

        Show
        ingenthr Matt Ingenthron added a comment - It's roughly http://www.couchbase.com/wiki/display/couchbase/Contributing+Changes Repo tool isn't required for this project though
        Hide
        ingenthr Matt Ingenthron added a comment -

        Also, Brett: saw your CLA on review.couchbase.org and you're all set.

        Show
        ingenthr Matt Ingenthron added a comment - Also, Brett: saw your CLA on review.couchbase.org and you're all set.
        Hide
        mnunberg Mark Nunberg added a comment -

        Unfortunately libevent doesn't really support Windows except by means of gcc/autotools and some other complicated steps. Given that we only support our binary Visual Studio builds, getting libevent to run well on Windows would be not very fruitful. We might revisit this if and when libevent will support Visual Studio. Until then, I'm marking this as won't fix.

        Show
        mnunberg Mark Nunberg added a comment - Unfortunately libevent doesn't really support Windows except by means of gcc/autotools and some other complicated steps. Given that we only support our binary Visual Studio builds, getting libevent to run well on Windows would be not very fruitful. We might revisit this if and when libevent will support Visual Studio. Until then, I'm marking this as won't fix.

          People

          • Assignee:
            mnunberg Mark Nunberg
            Reporter:
            brettharrison Brett Harrison
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes