Uploaded image for project: 'Couchbase C client library libcouchbase'
  1. Couchbase C client library libcouchbase
  2. CCBC-1363

Allow LCB build to use HdrHistogram_c from parent project

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 3.1.0
    • None
    • None
    • 1

    Description

      libcouchbase is part of Server builds. Both libcouchbase and Server builds use HdrHistogram_c. Since both Server and libcouchbase CMakeLists.txt do INCLUDE_SUBDIRECTORY() for HdrHistogram_c, the Server build fails at CMake time with a "duplicate target hdr_histogram" error.

      For now we're working around this by settingĀ LCB_USE_HDR_HISTOGRAM=off when building libcouchbase. This isn't ideal, though, as it disables HdrHistogram_c entirely for the libcouchbase build. It would be better for libcouchbase/CMakeLists.txt to detect that HdrHistogram_c is already available in the build (for instance by checking IF (TARGET hdr_histogram) ) and not adding the contrib/HdrHistogram_c directory in that case.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            Build couchbase-server-7.0.0-4433 contains libcouchbase commit 465188d with commit message:
            CCBC-1363: Allow using parent project's hdr_histogram_static target

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.0.0-4433 contains libcouchbase commit 465188d with commit message: CCBC-1363 : Allow using parent project's hdr_histogram_static target

            People

              ceej Chris Hillery
              ceej Chris Hillery
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty