Uploaded image for project: 'Couchbase C client library libcouchbase'
  1. Couchbase C client library libcouchbase
  2. CCBC-789

Don't sent empty 'Authorization' header

    XMLWordPrintable

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.7.2, 2.7.3, 2.7.4, 2.7.5
    • 2.7.6
    • library
    • None

    Attachments

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

      Activity

        Don't send an empty username/password. This broke because we don't check empty strings.

        mnunberg Mark Nunberg (Inactive) added a comment - Don't send an empty username/password. This broke because we don't check empty strings.

        I seem to get a similar issue with buckets that have a password - I assume again because I'm not specifying a username, just the password. Could the username be set to the bucket name if not specified? as with previous versions of the library

         

        takach Stephen von Takach added a comment - I seem to get a similar issue with buckets that have a password - I assume again because I'm not specifying a username, just the password. Could the username be set to the bucket name if not specified? as with previous versions of the library  

        Actually it's only the flush request via the lcb_cbflush3 that seems to fail with a HTTP error

         

        takach Stephen von Takach added a comment - Actually it's only the flush request via the lcb_cbflush3 that seems to fail with a HTTP error  

        It's probably related to the HTTP APIs. lcb_cbflush3 is rather odd in that it looks like a kv/memcached API, but is actually done over HTTP.

        Have you tried the patch and does it work for you? or is the issue still not fixed.

        mnunberg Mark Nunberg (Inactive) added a comment - It's probably related to the HTTP APIs. lcb_cbflush3 is rather odd in that it looks like a kv/memcached API, but is actually done over HTTP. Have you tried the patch and does it work for you? or is the issue still not fixed.

        Yeah, I built against the latest commit and HTTP requests are working as expected. My tests for lcb_cbflush3 are failing against couch 4.6.3 and passing against 3.1.6 however early versions of libcouchbase (i.e. 2.7.0) passed against both

        takach Stephen von Takach added a comment - Yeah, I built against the latest commit and HTTP requests are working as expected. My tests for lcb_cbflush3 are failing against couch 4.6.3 and passing against 3.1.6 however early versions of libcouchbase (i.e. 2.7.0) passed against both

        I take that back - lcb_cbflush3 is failing against both CB4.6.3 and 3.1.6 with the edge version of libcouchbase.

        Working with 2.7.1 of libcouchbase

         

        (the CB3.1.6 tests I ran earlier were running with an older version of libcouchbase)

         

        takach Stephen von Takach added a comment - I take that back - lcb_cbflush3 is failing against both CB4.6.3 and 3.1.6 with the edge version of libcouchbase. Working with 2.7.1 of libcouchbase   (the CB3.1.6 tests I ran earlier were running with an older version of libcouchbase)  
        takach Stephen von Takach added a comment - - edited

        Seem to have issue with authenticated requests. Basically this fix has solved requests going to the default bucket.

        When using lcb_create_st3 with connstr and passwd set (for authenticated buckets) the HTTP requests still fail.

         

        takach Stephen von Takach added a comment - - edited Seem to have issue with authenticated requests. Basically this fix has solved requests going to the default bucket. When using lcb_create_st3 with connstr and passwd set (for authenticated buckets) the HTTP requests still fail.  

        People

          mnunberg Mark Nunberg (Inactive)
          mnunberg Mark Nunberg (Inactive)
          Votes:
          1 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

            Created:
            Updated:
            Resolved:

            Gerrit Reviews

              There are no open Gerrit changes

              PagerDuty