Uploaded image for project: 'Couchbase Monitoring and Observability Stack'
  1. Couchbase Monitoring and Observability Stack
  2. CMOS-154

Add check for DCP names > 200 chars (MB-34280)

    XMLWordPrintable

Details

    Description

      This has hit quite a few people and could cause serious issues when upgrading from 6.x to 7. Be good to have a check for it.

      DCP names are exposed when requesting the stats group dcp over the memcached protocol - we already have code that uses this data, should be possible to piggyback on it.

      Attachments

        Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. MB-34280 Memcached should disallow DCP connections with names greater than 200 characters (was: ns_server connections may be terminated if a client uses a long DCP_OPEN.name)

          • Major - Major loss of function.
          • Closed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            Ascending order - Click to sort in descending order
            marks.polakovs Marks Polakovs added a comment -

            Moving back to In Progress as I noticed a mistake in the patch (right after merging it...) - the tests have stream names in the format "eq_dcpq:replication:ns_1@127.0.0.1->ns_2@127.0.0.1:bucket:max_buffer_bytes" but they shouldn't include the stat name at the end (and since the tests pass, that implies the code itself is wrong).

            marks.polakovs Marks Polakovs added a comment - Moving back to In Progress as I noticed a mistake in the patch (right after merging it...) - the tests have stream names in the format "eq_dcpq:replication:ns_1@127.0.0.1->ns_2@127.0.0.1:bucket:max_buffer_bytes" but they shouldn't include the stat name at the end (and since the tests pass, that implies the code itself is wrong).
            build-team Couchbase Build Team added a comment -

            Build couchbase-cluster-monitor-1.0.0-129 contains cbmultimanager commit 8e28b25 with commit message:
            CMOS-154 Add checker for long DCP names

            build-team Couchbase Build Team added a comment - Build couchbase-cluster-monitor-1.0.0-129 contains cbmultimanager commit 8e28b25 with commit message: CMOS-154 Add checker for long DCP names
            marks.polakovs Marks Polakovs added a comment -

            Verifying this is tricky, because I'm struggling to create a cluster with hostnames such that the DCP stream names are longer than 200 characters but shorter than (255 - length of the longest DCP stat name), otherwise memcached will fail to send the stats reply we're looking for and thus the checker will fail.

            Now that we can do Loki alerts (cf. CMOS-211) I might add a couple rules there for detecting the telltale log messages, that way we can catch this even if Cluster Monitor can't.

            marks.polakovs Marks Polakovs added a comment - Verifying this is tricky, because I'm struggling to create a cluster with hostnames such that the DCP stream names are longer than 200 characters but shorter than (255 - length of the longest DCP stat name), otherwise memcached will fail to send the stats reply we're looking for and thus the checker will fail. Now that we can do Loki alerts (cf. CMOS-211 ) I might add a couple rules there for detecting the telltale log messages, that way we can catch this even if Cluster Monitor can't.

            People

              marks.polakovs Marks Polakovs
              marks.polakovs Marks Polakovs
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty