Details

    • Technical task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • Mobile 2.5
    • Mobile 2.5
    • couchbase-lite

    Attachments

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

      Activity

        blake.meike Blake Meike added a comment -

        Ok.... Given the time constraints,  I will grudgingly add to this

        I want to be clear, right now, though, that all that this code demonstrates is that we are absolutely clueless about Android.  I am not stretching the truth at all to say that an intern at any reasonable Android shop who wrote code like this would be shown the door immediately.  We must set aside time, somewhere, to fix this stuff, before we embarrass ourselves completely.

        We must let go of the idea that Android is just iOS for the international community, or something.  We cannot continue to "translate" Swift models into Android code.  It doesn't work that way.

        A lot of "must"s in there, I realize, but this is seriously bad stuff.  Really.

        blake.meike Blake Meike added a comment - Ok.... Given the time constraints,  I will grudgingly add to this I want to be clear, right now, though, that all that this code demonstrates is that we are absolutely clueless about Android.  I am not stretching the truth at all to say that an intern at any reasonable Android shop who wrote code like this would be shown the door immediately.  We must set aside time, somewhere, to fix this stuff, before we embarrass ourselves completely. We must let go of the idea that Android is just iOS for the international community, or something.  We cannot continue to "translate" Swift models into Android code.  It doesn't work that way. A lot of " must "s in there, I realize, but this is seriously bad stuff.  Really.
        blake.meike Blake Meike added a comment -

        Code snippet added as:

        public void testReplicationPushFilter() throws URISyntaxException
        public void testReplicationPullFilter() throws URISyntaxException
        

        Did not add corresponding adoc. Just holler if you need that.

        blake.meike Blake Meike added a comment - Code snippet added as: public void testReplicationPushFilter() throws URISyntaxException public void testReplicationPullFilter() throws URISyntaxException Did not add corresponding adoc. Just holler if you need that.

        Great! Which branch did you push to?

        jamiltz James Nocentini added a comment - Great! Which branch did you push to?
        blake.meike Blake Meike added a comment -

        Hadn't!  Now up at gbm/DOC-4969

        blake.meike Blake Meike added a comment - Hadn't!  Now up at gbm/ DOC-4969
        jamiltz James Nocentini added a comment - Cherry-picked on doc-4451 branch  https://github.com/couchbase/docs-couchbase-lite/commit/2983c9437ff8ca8d530fb405921da562dcae8ee1

        People

          blake.meike Blake Meike
          jamiltz James Nocentini
          Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

            Created:
            Updated:
            Resolved:

            Gerrit Reviews

              There are no open Gerrit changes

              PagerDuty