Uploaded image for project: 'Couchbase Go SDK'
  1. Couchbase Go SDK
  2. GOCBC-137

Network error while DCP streaming will cause Go panic

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.1.3
    • 1.2.1
    • library
    • None

    Description

      When a network error occurs on an open connection, all requests which are sitting in the connections opaque map will be sent an ErrNetwork error which is visible here:
      https://github.com/couchbase/gocbcore/blob/master/memdpipeline.go#L267

      OpenStream creates a PERSISTENT request, which sits in the above mentioned queue for long periods of time, if the above ErrNetwork callback is invoked, the handler for OpenStream will immediately panic due to trying to dereference a nil pointer here:
      https://github.com/couchbase/gocbcore/blob/master/agentops_dcp.go#L44

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            There are no comments yet on this issue.

            People

              brett19 Brett Lawson
              brett19 Brett Lawson
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty