Uploaded image for project: 'Couchbase Go SDK'
  1. Couchbase Go SDK
  2. GOCBC-144

Close() does not return an error, probably indicative of latent bugs

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 1.2.1
    • 1.2.0
    • library
    • None

    Description

      It appears Close() doesn't return an error, but it also appears this is from gocbcore's Agent that doesn't return an error.  Closing something might fail which wouldn't be communicated upstream. 

      Also, note that it could be an io.Closer.

      Recommend running `go vet` and fixing those, followed by `golint` to make things more consistent.  

      Could also run github.com/kisielk/errcheck which shows the places errors are dropped.

      Attachments

        For Gerrit Dashboard: GOCBC-144
        # Subject Branch Project Status CR V

        Activity

          People

            brett19 Brett Lawson
            ingenthr Matt Ingenthron
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty