Uploaded image for project: 'Couchbase Go SDK'
  1. Couchbase Go SDK
  2. GOCBC-199

Add support for SUBDOC_MULTI_PATH_FAILURE_DELETED

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.3
    • Component/s: None
    • Labels:
      None

      Description

      Server has added a new error code, SUBDOC_MULTI_PATH_FAILURE_DELETED, that's returned when a multi-lookup operation partially succeeded/failed, and the document was deleted.

      https://github.com/couchbase/memcached/blob/f2d8f212b51983861a70df06d16af2d45ce87c13/include/memcached/protocol_binary.h#L247

      https://github.com/couchbase/memcached/commit/c61faf1c83c9dbc426d29b39a8abc3779c599cc3

      To leverage the functionality associated with this new code, Sync Gateway needs some SDK enhancements:

      • Add an error code to gocbcore.error.go so that we can recognize the error 
      • Don't terminate subdoc response processing on this error (similar to SUBDOC_MULTI_PATH_FAILURE)

       

       

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          Hide
          brett19 Brett Lawson added a comment -

          Adam Fraser: Would you be able to review the change-sets attached and confirm they are what you needed?

          Show
          brett19 Brett Lawson added a comment - Adam Fraser : Would you be able to review the change-sets attached and confirm they are what you needed?
          Hide
          build-team Couchbase Build Team added a comment -

          Build 5.0.0-3093 contains gocbcore commit 298e91109db554fccfc8eee499900aea1601a8ac with commit message:
          GOCBC-199: Added new subdoc error codes and error handling.
          https://github.com/couchbase/gocbcore/commit/298e91109db554fccfc8eee499900aea1601a8ac

          Show
          build-team Couchbase Build Team added a comment - Build 5.0.0-3093 contains gocbcore commit 298e91109db554fccfc8eee499900aea1601a8ac with commit message: GOCBC-199 : Added new subdoc error codes and error handling. https://github.com/couchbase/gocbcore/commit/298e91109db554fccfc8eee499900aea1601a8ac
          Hide
          build-team Couchbase Build Team added a comment -

          Build 5.0.0-3093 contains gocb commit 1e0d7ef241c55317437b01cebe7f333a9e9fc727 with commit message:
          GOCBC-199: Added new subdoc error codes.
          https://github.com/couchbase/gocb/commit/1e0d7ef241c55317437b01cebe7f333a9e9fc727

          Show
          build-team Couchbase Build Team added a comment - Build 5.0.0-3093 contains gocb commit 1e0d7ef241c55317437b01cebe7f333a9e9fc727 with commit message: GOCBC-199 : Added new subdoc error codes. https://github.com/couchbase/gocb/commit/1e0d7ef241c55317437b01cebe7f333a9e9fc727

            People

            • Assignee:
              brett19 Brett Lawson
              Reporter:
              adamf Adam Fraser
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes

                  PagerDuty

                  Error rendering 'com.pagerduty.jira-server-plugin:PagerDuty'. Please contact your Jira administrators.