Major Description
The SDK HELO version seems incorrect.
Steps to reproduce:
- Spin up a one node cluster with the default bucket
- Use the following Go code
package mainimport ("fmt""gopkg.in/couchbase/gocb.v1")type User struct {Id string `json:"uid"`Email string `json:"email"`Interests []string `json:"interests"`}func main() {gocb.SetLogger(gocb.DefaultStdioLogger())cluster, _ := gocb.Connect("couchbase://localhost")bucket, _ := cluster.OpenBucket("default", "")bucket.Upsert("u:kingarthur",User{Id: "kingarthur",Email: "kingarthur@couchbase.com",Interests: []string{"Holy Grail", "African Swallows"},}, 0)var inUser Userbucket.Get("u:kingarthur", &inUser)fmt.Printf("User: %v\n", inUser)} - build and execute
- Tail the memcached.log:
2017-11-10T18:26:58.200201Z NOTICE 43: HELO [gocb/v7.0.5] [ 10.111.163.1:64882 - 10.111.163.101:11207 ]2017-11-10T18:26:58.205011Z WARNING 43 Closing connection [ 10.111.163.1:64882 - 10.111.163.101:11207 ] due to read error: Connection reset by peer
As you can see the HELO version of the SDK is gocb/v7.0.5 I was expecting 1.30, as I believe that is the SDK version being used.
Attachments
| For Gerrit Dashboard: GOCBC-248 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 87861,2 | GOCBC-248: Uniquely identify gocb version to the core. | master | gocb | Status: MERGED | -1 | +1 |
| 87864,2 | GOCBC-248: Uniquely identify gocb version along with core version. | v7 | gocbcore | Status: MERGED | +2 | +1 |
Activity
Hey Patrick,
What would be the benefit of this? The gocb library doesn't have any tangible impact on the clients behavior, its simply a forwarding layer.
Cheers, Brett
Closing this for now, please feel free to reopen it if there is some support use for this!
What would be the benefit of this? The gocb library doesn't have any tangible impact on the clients behavior, its simply a forwarding layer.
So we can identify problematic SDK versions and proactively inform customer.
From a end user DBA point of view they can see what clients are connected and what versions they are on.
This is what the other SDKs too:
- Java SDK sets both the core and top level client versions in the HELO
- Python SDK sets the libcouchbase and python SDK versions in the HELO
Build couchbase-server-5.1.0-5537 contains gocbcore commit a4afac19160b9b2d88320210d07fd5c55f8c385d with commit message:
GOCBC-248: Uniquely identify gocb version along with core version.
https://github.com/couchbase/gocbcore/commit/a4afac19160b9b2d88320210d07fd5c55f8c385d
Build couchbase-server-5.5.0-1708 contains gocbcore commit a4afac19160b9b2d88320210d07fd5c55f8c385d with commit message:
GOCBC-248: Uniquely identify gocb version along with core version.
https://github.com/couchbase/gocbcore/commit/a4afac19160b9b2d88320210d07fd5c55f8c385d
Build couchbase-server-5.5.0-2097 contains gocb commit 77854e87edf350a2eedd1d29ad2998a1dc9b47da with commit message:
GOCBC-248: Uniquely identify gocb version to the core.
https://github.com/couchbase/gocb/commit/77854e87edf350a2eedd1d29ad2998a1dc9b47da
Build couchbase-server-5.5.0-2114 contains gocb commit 77854e87edf350a2eedd1d29ad2998a1dc9b47da with commit message:
GOCBC-248: Uniquely identify gocb version to the core.
https://github.com/couchbase/gocb/commit/77854e87edf350a2eedd1d29ad2998a1dc9b47da
Build sync_gateway-2.1.0-839 contains gocb commit 77854e87edf350a2eedd1d29ad2998a1dc9b47da with commit message:
GOCBC-248: Uniquely identify gocb version to the core.
https://github.com/couchbase/gocb/commit/77854e87edf350a2eedd1d29ad2998a1dc9b47da
Build sync_gateway-2.1.0-839 contains gocbcore commit a4afac19160b9b2d88320210d07fd5c55f8c385d with commit message:
GOCBC-248: Uniquely identify gocb version along with core version.
https://github.com/couchbase/gocbcore/commit/a4afac19160b9b2d88320210d07fd5c55f8c385d
Build couchbase-server-5.1.2-6014 contains gocb commit 77854e8 with commit message:
GOCBC-248: Uniquely identify gocb version to the core.
Build couchbase-server-5.1.1-5904 contains gocb commit 77854e8 with commit message:
GOCBC-248: Uniquely identify gocb version to the core.
Hey Patrick Varley,
The Go SDK is actually made up of two somewhat independently developed projects, gocbcore which implements all of the connection, protocol and configuration management, as well as gocb on top which provides a more sane API for developers to use. The version which is reported to the server is the gocbcore version (as this is the one which would actually impact the behaviour of the client). Note that the reason we cannot send the gocb version is that there is no way to map a specific gocb version to a specific gocbcore version due to how Go's package management works. For instance, if you checked out gocb last month, you would get gocb.v1.3.0 and gocbcore v7.0.4. However, doing the exact same installation today would yield instead gocb.v1.3.0 and gocbcore v7.0.5. Note that the gocb version hasn't been updated, but gocbcore underneath has been.
Cheers, Brett