Uploaded image for project: 'Couchbase Java Client'
  1. Couchbase Java Client
  2. JCBC-144

flush command needs to use RESTful flush for Couchbase Buckets

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0
    • Component/s: Core
    • Security Level: Public
    • Labels:
      None

      Description

      The current flush command needs to be connected to the RESTful flush.

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        ingenthr Matt Ingenthron created issue -
        ingenthr Matt Ingenthron made changes -
        Field Original Value New Value
        Priority Major [ 3 ] Blocker [ 1 ]
        ingenthr Matt Ingenthron made changes -
        Assignee Raghavan Srinivas [ rags ] Michael Nitschinger [ daschl ]
        Hide
        daschl Michael Nitschinger added a comment -

        To my findings there are two ways to implement this feature:

        • Reuse the BucketManager for this, since it already provides basic capabilities for flushing (but needs some extension).
        • Reimplement the whole thing.

        I would go with extending the BucketManager for this, since it would also keep the CouchbaseClient itself lean.

        There is one thing that we need to decide upon: we can't just override the flush() method, because the returned value is different (we can't return an operation future with the current implementation). If we want to, we could "fake" it into one (but I doubt it makes sense). Therefore I propose a new method (flushBucket) which should be used with the couchbase client and we need to document that the old flush methods only work against memcached servers.

        Show
        daschl Michael Nitschinger added a comment - To my findings there are two ways to implement this feature: Reuse the BucketManager for this, since it already provides basic capabilities for flushing (but needs some extension). Reimplement the whole thing. I would go with extending the BucketManager for this, since it would also keep the CouchbaseClient itself lean. There is one thing that we need to decide upon: we can't just override the flush() method, because the returned value is different (we can't return an operation future with the current implementation). If we want to, we could "fake" it into one (but I doubt it makes sense). Therefore I propose a new method (flushBucket) which should be used with the couchbase client and we need to document that the old flush methods only work against memcached servers.
        Hide
        daschl Michael Nitschinger added a comment -
        Show
        daschl Michael Nitschinger added a comment - Tracked here: http://review.couchbase.com/#/c/22445/
        daschl Michael Nitschinger made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        daschl Michael Nitschinger made changes -
        Issue Type Bug [ 1 ] New Feature [ 2 ]
        daschl Michael Nitschinger made changes -
        Assignee Michael Nitschinger [ daschl ] Matt Ingenthron [ ingenthr ]
        daschl Michael Nitschinger made changes -
        Fix Version/s 1.1beta [ 10370 ]
        Fix Version/s 1.1-dp5 [ 10410 ]
        Hide
        ingenthr Matt Ingenthron added a comment -

        Pushing out to release 1.1.0, as it's secondary functionality.

        Show
        ingenthr Matt Ingenthron added a comment - Pushing out to release 1.1.0, as it's secondary functionality.
        ingenthr Matt Ingenthron made changes -
        Fix Version/s 1.1.0 [ 10274 ]
        Fix Version/s 1.1-beta [ 10370 ]
        Flagged [Release Note]
        Show
        ingenthr Matt Ingenthron added a comment - http://review.couchbase.org/#/c/22445/
        ingenthr Matt Ingenthron made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        ingenthr Matt Ingenthron made changes -
        Workflow jira [ 21691 ] Couchbase SDK Workflow [ 38431 ]

          People

          • Assignee:
            ingenthr Matt Ingenthron
            Reporter:
            ingenthr Matt Ingenthron
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes