Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1-beta
    • Component/s: Core
    • Security Level: Public
    • Labels:
      None
    No reviews matched the request. Check your Options in the drop-down menu of this sections header.

      Activity

      Hide
      mikew Mike Wiederhold added a comment -

      This bug may be vague, but I don't think we should close it until we actually add more view tests to our unit testing. I constantly hear from the support team for example that users are sending valid queries that are put together incorrectly by the client. It is tests like these that should be added.

      Show
      mikew Mike Wiederhold added a comment - This bug may be vague, but I don't think we should close it until we actually add more view tests to our unit testing. I constantly hear from the support team for example that users are sending valid queries that are put together incorrectly by the client. It is tests like these that should be added.
      Hide
      ingenthr Matt Ingenthron added a comment -

      as part of JCBC-41, etc. I'm adding a number of different query types, including complex queries.

      Show
      ingenthr Matt Ingenthron added a comment - as part of JCBC-41 , etc. I'm adding a number of different query types, including complex queries.
      Hide
      daschl Michael Nitschinger added a comment -

      I've been adding view tests here, are there some areas where we can improve further (or any scenarios that are not covered here):

      http://review.couchbase.com/#/c/21338/
      http://review.couchbase.com/#/c/21305/

      Also I've been adding new ComplexKey and query unit tests here that should prove the correct functionality:

      http://review.couchbase.com/#/c/21337/

      Show
      daschl Michael Nitschinger added a comment - I've been adding view tests here, are there some areas where we can improve further (or any scenarios that are not covered here): http://review.couchbase.com/#/c/21338/ http://review.couchbase.com/#/c/21305/ Also I've been adding new ComplexKey and query unit tests here that should prove the correct functionality: http://review.couchbase.com/#/c/21337/
      Hide
      mikew Mike Wiederhold added a comment -

      This is great progress on this issue. Once you have figured out where we are lacking on testing for views feel free to close this and open up some more specific issues.

      Show
      mikew Mike Wiederhold added a comment - This is great progress on this issue. Once you have figured out where we are lacking on testing for views feel free to close this and open up some more specific issues.
      Hide
      ingenthr Matt Ingenthron added a comment -

      Would like Michael N. to open specific issues as recommended and then close this issue.

      Show
      ingenthr Matt Ingenthron added a comment - Would like Michael N. to open specific issues as recommended and then close this issue.
      Hide
      daschl Michael Nitschinger added a comment -

      I think we are in pretty good shape with view tests now, since the query object is unit tested and we have view tests in place for (hopefully) all the params and also for observe-variations in combination with stale = false.

      If special issues come up we can reopen a specific issue for them as noted.

      Show
      daschl Michael Nitschinger added a comment - I think we are in pretty good shape with view tests now, since the query object is unit tested and we have view tests in place for (hopefully) all the params and also for observe-variations in combination with stale = false. If special issues come up we can reopen a specific issue for them as noted.

        People

        • Assignee:
          daschl Michael Nitschinger
          Reporter:
          mikew Mike Wiederhold
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Gerrit Reviews

            There are no open Gerrit changes