Uploaded image for project: 'Java DCP Client'
  1. Java DCP Client
  2. JDCP-94

Should never pass null ChannelFlowController to event handlers

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.16.0
    • Fix Version/s: 0.17.0
    • Labels:
      None
    • Story Points:
      1

      Description

      In two places, DcpChannel passes a null ChannelFlowController to ControllEventHandler.onEvent. These two events don't actually need to be ack'd, but the contract is that it's always safe for event handlers to attempt the ack, and it's up to the  ChannelFlowController to decide whether the event actually requires acknowledgement.

       

       

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          david.nault David Nault created issue -
          david.nault David Nault made changes -
          Field Original Value New Value
          Status New [ 10003 ] Open [ 1 ]
          david.nault David Nault made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          david.nault David Nault made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Resolved [ 5 ]
          brett19 Brett Lawson made changes -
          Story Points 1

            People

            Assignee:
            david.nault David Nault
            Reporter:
            david.nault David Nault
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes

                  PagerDuty