Loading...

XML

Word

Printable

the js side of the lcb store callback expects a triple of (err, cas, token) the js callback expects (err, cas, token) https://github.com/couchbase/couchnode/blob/3d0b7e8ef249ac2c912845320e5742b6fa6ff197/lib/collection.js#L473
but the LCB side only writes (err, token) and omits the cas.. now the token is treated as the cas.

No reviews matched the request. Check your Options in the drop-down menu of this sections header.

There are no open Gerrit changes

Hide There are 3 closed Gerrit changes

JSCBC-669, JSCBC-670: Fixed callbacks not sending cas and initial value parsing Motivation ---------- The callback for handling store operations was not correctly passing the cas values back to the Node.js callback. Additionally, the `initial` value for counter operations is not being parsed appropriately due to a conflict with CAS parsing. Changes ------- Fixed store callback to return cas along with errors and mutation tokens. Renamed parseOption to parseCasOption for cas, and created a new parseOption(uint64) for parsing other options/parameters.: Gerrit Review:

JSCBC-669, JSCBC-670: Fixed callbacks not sending cas and initial value parsing Motivation ---------- The callback for handling store operations was not correctly passing the cas values back to the Node.js callback. Additionally, the `initial` value for counter operations is not being parsed appropriately due to a conflict with CAS parsing. Changes ------- Fixed store callback to return cas along with errors and mutation tokens. Renamed parseOption to parseCasOption for cas, and created a new parseOption(uint64) for parsing other options/parameters.: Gerrit Review:

LCB store callback confuses cas and token