Uploaded image for project: 'Java Couchbase JVM Core'
  1. Java Couchbase JVM Core
  2. JVMCBC-541

Threshold span count cannot be above sample size

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 1.6.0
    • None
    • None
    • None
    • 1

    Description

      ThresholdLogReporter > updateSet remove items from the set when over the sample size, however when convertThresholdSet builds the JSON to log, the count will be the set size, not the total number of spans that were recorded
      eg say 30 spans are reported, when adding to the set via updateSet, once the sampleSize is reached, spans are removed but there isn't a total number of spans that were added, we instead use the set size, which will equal the sample size
      https://github.com/couchbase/couchbase-jvm-core/blob/master/src/main/java/com/couchbase/client/core/... <- updateSet
      https://github.com/couchbase/couchbase-jvm-core/blob/master/src/main/java/com/couchbase/client/core/... <- convertThresholdSet

      Each service set should have a total count that tracks the number of spans that were added to the set, which is not tied to the set size. This count should also be reset during the logging process.

      Attachments

        For Gerrit Dashboard: JVMCBC-541
        # Subject Branch Project Status CR V

        Activity

          People

            graham.pople Graham Pople
            mike.goldsmith Michael Goldsmith
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty