Uploaded image for project: 'Couchbase Kubernetes'
  1. Couchbase Kubernetes
  2. K8S-2338

backOffLimit field is not working in Helm Chart

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • None
    • helm, kubernetes
    • None
    • 1

    Description

      Background

      a backup config like so with the Helm chart

      backups:
       
      default-backup:
       
      # name: my-backup
       
      strategy: full_only
       
      full:
       
      schedule: "15 6 * * *"
       
      successfulJobsHistoryLimit: 1
       
      failedJobsHistoryLimit: 3
       
      backOffLimit: 2
       
      backupRetention: 24h
       
      logRetention: 24h
       
      size: 100Gi
       
      storageClassName: "px-sci-cb-backup-storageclass"
      

      Problem
      This error will occur:

       
      Error: UPGRADE FAILED: error validating "": error validating data: [ValidationError(CouchbaseBackup.spec): unknown field "backOffLimit" in com.couchbase.v2.CouchbaseBackup.spec, ValidationError(CouchbaseBackup.spec): unknown field "name" in com.couchbase.v2.CouchbaseBackup.spec]
      

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          This looks to be two simple issues:

          1. Typo with the case being used for `backoffLimit`
          2. The old beta CRDs allowed extra fields in the spec which are ignored but as we are GA now we have to make sure they are excluded - there was a similar issue with the buckets previously using the `kind` field which has to be explicitly ignored now. Strict validation rather than the looser beta validation means the `name` field needs to be removed.
          patrick.stephens Patrick Stephens (Inactive) added a comment - - edited This looks to be two simple issues: Typo with the case being used for `backoffLimit` The old beta CRDs allowed extra fields in the spec which are ignored but as we are GA now we have to make sure they are excluded - there was a similar issue with the buckets previously using the `kind` field which has to be explicitly ignored now. Strict validation rather than the looser beta validation means the `name` field needs to be removed.

          Changes made to resolve this: https://github.com/couchbase-partners/helm-charts/pull/62 

          Tested by using the examples directly in the repo.

          test.yaml

          helm upgrade --install test <repo-dir> --values test.yaml

          patrick.stephens Patrick Stephens (Inactive) added a comment - - edited Changes made to resolve this: https://github.com/couchbase-partners/helm-charts/pull/62   Tested by using the examples directly in the repo. test.yaml helm upgrade --install test <repo-dir> --values test.yaml

          This should be resolved now with 2.2.102 - make sure to run a `helm repo update` as well.

          patrick.stephens Patrick Stephens (Inactive) added a comment - This should be resolved now with 2.2.102 - make sure to run a `helm repo update` as well.

          Feel free to close once confirmed this is ok.

          patrick.stephens Patrick Stephens (Inactive) added a comment - Feel free to close once confirmed this is ok.

          Thank you Patrick Stephens I will confirm with customer

          tin.tran Tin Tran (Inactive) added a comment - Thank you Patrick Stephens I will confirm with customer
          tin.tran Tin Tran (Inactive) added a comment - - edited

          hi Patrick Stephens
          The customer is using the Helm Chart version: 2.2.103

          and they're still hitting the error with backofflimit.

          Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(CouchbaseBackup.spec): unknown field "backOffLimit" in com.couchbase.v2.CouchbaseBackup.spec

          Can you please help check? I have also asked for the cbopinfo and will update.

          tin.tran Tin Tran (Inactive) added a comment - - edited hi Patrick Stephens The customer is using the Helm Chart version: 2.2.103 and they're still hitting the error with backofflimit. Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(CouchbaseBackup.spec): unknown field "backOffLimit" in com.couchbase.v2.CouchbaseBackup.spec Can you please help check? I have also asked for the cbopinfo and will update.

          They need to specify `backoffLimit` (note the case of the 'o'), I've updated the example for this - there is no change otherwise to the chart.

          https://github.com/couchbase-partners/helm-charts/blob/master/charts/couchbase-operator/values.yaml#L129

          On previous versions, as CRDs were not GA, it would just ignore unknown fields so whilst it looked like it worked it only passed validation and the setting was ignored.

          patrick.stephens Patrick Stephens (Inactive) added a comment - - edited They need to specify `backoffLimit` (note the case of the 'o'), I've updated the example for this - there is no change otherwise to the chart. https://github.com/couchbase-partners/helm-charts/blob/master/charts/couchbase-operator/values.yaml#L129 On previous versions, as CRDs were not GA, it would just ignore unknown fields so whilst it looked like it worked it only passed validation and the setting was ignored.

          Confirmed with Tin Tran this is all ok now.

          patrick.stephens Patrick Stephens (Inactive) added a comment - Confirmed with Tin Tran this is all ok now.

          People

            patrick.stephens Patrick Stephens (Inactive)
            tin.tran Tin Tran (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty