Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-15614

ns_server sherlock in function names

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 4.5.0
    • 4.0.0
    • ns_server
    • Security Level: Public
    • None
    • Untriaged
    • Unknown

    Description

      I think using sherlock as function names is going to cause future confusion, in a couple years time it won't be obvious what the following means...

      ns_server/src/menelaus_web.erl

      966assert_is_sherlock() ->
      967 case cluster_compat_mode:is_cluster_sherlock() of
      968 true ->
      969 ok;
      970 false ->
      971 erlang:throw({web_exception,
      ....

      I know it's set with
      ns_server/src/cluster_compat_mode.erl
      81 is_cluster_sherlock() ->
      82 is_enabled([4, 0]).
      83

      Perhaps it would be good to change the function names to refer to Couchbase 4 not sherlock before it GAs.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              artem Artem Stemkovski
              ianmccloy Ian McCloy (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty