KVShard::setLowPriorityVbSnapshotFlag not working as expected

bool KVShard::setLowPriorityVbSnapshotFlag(bool lowPriority)

{ bool inverse = !lowPriority; return lowPrioritySnapshot.compare_exchange_strong(inverse, lowPrioritySnapshot); }

the compare exchange will compare lowPrioritySnapshot with !lowPriority if they are != nothing changes. If they are == lowPrioritySnapshot is replaced with lowPrioritySnapshot. And hence it still doesn't change.

The fix is that the 2nd parameter should be changed from lowPrioritySnapshot to lowPriority.