Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-18042

[FTS] UI: Remove Byte Array Converter from UI

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.5.0
    • Fix Version/s: 4.6.0, 5.0.0
    • Component/s: cbft
    • Security Level: Public
    • Labels:

      Description

      In the Advanced tab of Full Text Index editor, remove the Bye Array Converter Dropdown, which only has a single value that can't be changed and isn't particularly informative.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          Hide
          steve Steve Yen added a comment -

          just going to attempt a CSS level thing, hiding the control

          Show
          steve Steve Yen added a comment - just going to attempt a CSS level thing, hiding the control
          Hide
          steve Steve Yen added a comment -

          Hi Nimish,
          I think this is a two-step fix...

          step 1 idea is to add CSS classes to all the right places in bleve-mapping-ui

          step 2 is to hide or make invisible the control when used in cbft, by adding the right CSS rules to fts.css. But, keep the control actually there for the future when we support additional byte-array-converters.

          Show
          steve Steve Yen added a comment - Hi Nimish, I think this is a two-step fix... step 1 idea is to add CSS classes to all the right places in bleve-mapping-ui step 2 is to hide or make invisible the control when used in cbft, by adding the right CSS rules to fts.css. But, keep the control actually there for the future when we support additional byte-array-converters.
          Hide
          nimish Nimish Gupta added a comment -

          Hi Steve,
          I am thinking if we can disable it if number of byte array converter are equal to 1.

          Show
          nimish Nimish Gupta added a comment - Hi Steve, I am thinking if we can disable it if number of byte array converter are equal to 1.
          Hide
          will.gardella Will Gardella (Inactive) added a comment -

          Just need to release note that index definitions created in earlier releases will not work unless you remove the "byte_array_converter": "json" attribute value pair from the index definition JSON.

            "params": {
              "mapping": {
                "byte_array_converter": "json",
                "default_analyzer": "standard",
                "default_datetime_parser": "dateTimeOptional",
                "default_field": "_all",
                "default_mapping": {
                  "display_order": "1",
                  "dynamic": true,
                  "enabled": false
                }
          

          Show
          will.gardella Will Gardella (Inactive) added a comment - Just need to release note that index definitions created in earlier releases will not work unless you remove the "byte_array_converter": "json" attribute value pair from the index definition JSON. "params" : { "mapping" : { "byte_array_converter" : "json" , "default_analyzer" : "standard" , "default_datetime_parser" : "dateTimeOptional" , "default_field" : "_all" , "default_mapping" : { "display_order" : "1" , "dynamic" : true , "enabled" : false }
          Hide
          will.gardella Will Gardella (Inactive) added a comment -

          Fix was shipped in 4.6 too.

          Show
          will.gardella Will Gardella (Inactive) added a comment - Fix was shipped in 4.6 too.
          Hide
          pvarley Patrick Varley added a comment -

          Will Gardella Can you please put a link to the bleve commit for this changed.

          Show
          pvarley Patrick Varley added a comment - Will Gardella Can you please put a link to the bleve commit for this changed.
          Show
          will.gardella Will Gardella (Inactive) added a comment - - edited CBFT Change https://github.com/couchbase/cbft/commit/9393ddaeb2432d6dcf772f670c6f723dcec04422 https://github.com/couchbase/cbft/commit/ea44918ac1cc30c6d54138a74eb79e6da1273b88 Bleve Change https://github.com/blevesearch/bleve/commit/81282b3c06b8cce86    

            People

            • Assignee:
              pvarley Patrick Varley
              Reporter:
              will.gardella Will Gardella (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes

                  PagerDuty

                  Error rendering 'com.pagerduty.jira-server-plugin:PagerDuty'. Please contact your Jira administrators.