Details
-
Improvement
-
Resolution: Fixed
-
Major
-
4.5.0
Description
From an email I circulated to the Query team...
(to iterate - an average of an extra 200us per request for a single line of logging only shows under load: the impact while dealing with a single request is much less).
_While testing MB-18841, I added a single line of logging to be output at each request.
Over 10 clients x 10k executions, this is what it averages to:
W/O
{{ {
"prepareds":
},}}
With
{{ {
"prepareds":
}}}
That's right – with all cores running at full blast, a single line of logging adds 200us, or, rephrased, adds 10% to the execution time.
By comparison, with a single client running, this adds 25us over 765us, or 3%.
This is probably down to the logging lock – here's probably some low hanging performance fruit we could pick…_
Attachments
For Gerrit Dashboard: MB-19881 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
143539,4 | MB-19881 Improve cost of logging | master | query | Status: MERGED | +2 | +1 |
143540,2 | MB-19881 Improve cost of logging | master | query-ee | Status: MERGED | +2 | +1 |
143541,3 | MB-19881 Improve cost of logging | master | goutils | Status: MERGED | +2 | +1 |
143669,2 | Revert "MB-19881 Improve cost of logging" | master | query | Status: ABANDONED | 0 | 0 |
143711,2 | MB-19881 Fix missing log redaction tags | master | query | Status: MERGED | +2 | +1 |