Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-20245

batchWarmupCallback doesn't check callback status

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 4.6.0
    • 3.0, 3.0.1, 3.0.2, 3.0.3, 3.1.0, 3.1.1, 3.1.2, 3.1.3, 3.1.4, 3.1.5, 4.0.0, 4.1.0, 4.1.1, 4.1.2, 4.5.0
    • couchbase-bucket

    Description

      The call to c->cb.callback doesn't check the status of the cb object for !SUCCESS after the call.

      The cb object is an instance of LoadStorageKVPairCallback which sets status to ENOMEM when warmup is done.

      This is quite hard to reproduce (i.e. not yet reproduced) as you need a severe DGM (big vbuckets) so you don't stop warmup at the metadata loading phase, but continue to loading access logs and find that say the first shard fills memory. The other threads will keep calling back using batchWarmupCallback without stopping.

      However reviewing the code reveals the issue.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            jwalker Jim Walker
            jwalker Jim Walker
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty