Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-22209

memcached reports socketError when actually socket is closed normally

    XMLWordPrintable

Details

    • Untriaged
    • Unknown

    Description

      If the socket recv call return 0 on a non piped connection, we report this as a SocketError.
      In fact this should be reported as SocketClosed.

      SocketError should be reserved for the case when the socket recv returns -1

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          Ascending order - Click to sort in descending order
          build-team Couchbase Build Team added a comment -

          Build 5.0.0-1612 contains memcached commit 096e4fec3901a8704fa7575ec284bf3e673e1941 with commit message:
          MB-22209: Only report socketError if recv returns an error
          https://github.com/couchbase/memcached/commit/096e4fec3901a8704fa7575ec284bf3e673e1941

          build-team Couchbase Build Team added a comment - Build 5.0.0-1612 contains memcached commit 096e4fec3901a8704fa7575ec284bf3e673e1941 with commit message: MB-22209 : Only report socketError if recv returns an error https://github.com/couchbase/memcached/commit/096e4fec3901a8704fa7575ec284bf3e673e1941
          drigby Dave Rigby added a comment -

          Daniel Owen Can this be resolved?

          drigby Dave Rigby added a comment - Daniel Owen Can this be resolved?
          owend Daniel Owen added a comment -

          Yes I will mark as resolved and close.

          owend Daniel Owen added a comment - Yes I will mark as resolved and close.

          People

            owend Daniel Owen
            owend Daniel Owen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty