Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-23139

[FTS] moss compaction unit test assumes one particular segment impl

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 5.0.0
    • 5.0.0
    • fts
    • None
    • Untriaged
    • Unknown

    Description

      These two tests:

      === RUN TestStoreCompaction
      — FAIL: TestStoreCompaction (0.09s)
      store_test.go:771: expected segment
      === RUN TestStoreCompactionDeferredSort
      — FAIL: TestStoreCompactionDeferredSort (0.08s)
      store_test.go:771: expected segment

      Which are 2 variants of the same testStoreCompaction() function.

      See: https://github.com/couchbase/moss/blob/master/store_test.go#L769

      It would be nice if the test assertions were independent of the actual implementation. Or perhaps there could be another testableSegment interface that we hook into...

      Attachments

        For Gerrit Dashboard: MB-23139
        # Subject Branch Project Status CR V

        Activity

          People

            mschoch Marty Schoch [X] (Inactive)
            mschoch Marty Schoch [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty