Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-25630

Add read-only KVStore fsTimings to timing stats

    XMLWordPrintable

Details

    Description

      During investigation of slow background fetches on a customer environment, I found that while we record filesystem timings for both read-only and read-write KVStores, we only report the timings for read-write:

      void KVStore::addTimingStats(ADD_STAT add_stat, const void *c) {
       
          /* We don't support any timing stats for read-only instances
           * at this point.
           */
          if (isReadOnly()) {
              return;
          }
      

      To better assist in analysing read timings, we should also include the read-only instance in the stats (accessed via the kvtimings cbstats group).

      Attachments

        Activity

          Build 5.1.0-1235 contains kv_engine commit c35bd2581cbfeede31fd4c0c229ff1f8c16007e9 with commit message:
          MB-25630: Include read-only KVStore stats in 'cbstats kvtimings'
          https://github.com/couchbase/kv_engine/commit/c35bd2581cbfeede31fd4c0c229ff1f8c16007e9

          build-team Couchbase Build Team added a comment - Build 5.1.0-1235 contains kv_engine commit c35bd2581cbfeede31fd4c0c229ff1f8c16007e9 with commit message: MB-25630 : Include read-only KVStore stats in 'cbstats kvtimings' https://github.com/couchbase/kv_engine/commit/c35bd2581cbfeede31fd4c0c229ff1f8c16007e9
          bharath.gp Bharath G P added a comment -

          Validated on 4.6.4 build 4570.

          bharath.gp Bharath G P added a comment - Validated on 4.6.4 build 4570.

          Build 4.6.5-4707 contains testrunner commit 1198e41204ae5b466e669c1c04113ed14beef2cb with commit message:
          CBQE-4361 : Add testcases for MB-25630 (CBSE-4029)
          https://github.com/couchbase/testrunner/commit/1198e41204ae5b466e669c1c04113ed14beef2cb

          build-team Couchbase Build Team added a comment - Build 4.6.5-4707 contains testrunner commit 1198e41204ae5b466e669c1c04113ed14beef2cb with commit message: CBQE-4361 : Add testcases for MB-25630 (CBSE-4029) https://github.com/couchbase/testrunner/commit/1198e41204ae5b466e669c1c04113ed14beef2cb

          Build 5.0.2-5508 contains kv_engine commit 54e8ef67c306d1caffc05ee9614f7b0d996064f2 with commit message:
          MB-25630: Include read-only KVStore stats in 'cbstats kvtimings'
          https://github.com/couchbase/kv_engine/commit/54e8ef67c306d1caffc05ee9614f7b0d996064f2

          build-team Couchbase Build Team added a comment - Build 5.0.2-5508 contains kv_engine commit 54e8ef67c306d1caffc05ee9614f7b0d996064f2 with commit message: MB-25630 : Include read-only KVStore stats in 'cbstats kvtimings' https://github.com/couchbase/kv_engine/commit/54e8ef67c306d1caffc05ee9614f7b0d996064f2

          Build 5.5.0-1580 contains kv_engine commit 54e8ef67c306d1caffc05ee9614f7b0d996064f2 with commit message:
          MB-25630: Include read-only KVStore stats in 'cbstats kvtimings'
          https://github.com/couchbase/kv_engine/commit/54e8ef67c306d1caffc05ee9614f7b0d996064f2

          build-team Couchbase Build Team added a comment - Build 5.5.0-1580 contains kv_engine commit 54e8ef67c306d1caffc05ee9614f7b0d996064f2 with commit message: MB-25630 : Include read-only KVStore stats in 'cbstats kvtimings' https://github.com/couchbase/kv_engine/commit/54e8ef67c306d1caffc05ee9614f7b0d996064f2

          People

            drigby Dave Rigby
            drigby Dave Rigby
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              PagerDuty