Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-25630

Add read-only KVStore fsTimings to timing stats

    XMLWordPrintable

Details

    Description

      During investigation of slow background fetches on a customer environment, I found that while we record filesystem timings for both read-only and read-write KVStores, we only report the timings for read-write:

      void KVStore::addTimingStats(ADD_STAT add_stat, const void *c) {
       
          /* We don't support any timing stats for read-only instances
           * at this point.
           */
          if (isReadOnly()) {
              return;
          }
      

      To better assist in analysing read timings, we should also include the read-only instance in the stats (accessed via the kvtimings cbstats group).

      Attachments

        For Gerrit Dashboard: MB-25630
        # Subject Branch Project Status CR V

        Activity

          There are no commits yet on this issue.

          People

            drigby Dave Rigby
            drigby Dave Rigby
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              PagerDuty