Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-25630

Add read-only KVStore fsTimings to timing stats

    XMLWordPrintable

Details

    Description

      During investigation of slow background fetches on a customer environment, I found that while we record filesystem timings for both read-only and read-write KVStores, we only report the timings for read-write:

      void KVStore::addTimingStats(ADD_STAT add_stat, const void *c) {
       
          /* We don't support any timing stats for read-only instances
           * at this point.
           */
          if (isReadOnly()) {
              return;
          }
      

      To better assist in analysing read timings, we should also include the read-only instance in the stats (accessed via the kvtimings cbstats group).

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          drigby Dave Rigby created issue -
          drigby Dave Rigby made changes -
          Field Original Value New Value
          Link This issue depends on CBSE-4029 [ CBSE-4029 ]
          drigby Dave Rigby added a comment -

          Sriram Ganesan Please could you prepare and test patches for both master (targeting Vulcan) and watson branches (targeting a future 4.6.x).

          drigby Dave Rigby added a comment - Sriram Ganesan Please could you prepare and test patches for both master (targeting Vulcan) and watson branches (targeting a future 4.6.x).
          drigby Dave Rigby made changes -
          Assignee Dave Rigby [ drigby ] Sriram Ganesan [ sriram ]
          drigby Dave Rigby made changes -
          Link This issue depends on CBSE-4029 [ CBSE-4029 ]
          drigby Dave Rigby made changes -
          Link This issue relates to CBSE-4029 [ CBSE-4029 ]
          drigby Dave Rigby made changes -
          Rank Ranked higher
          drigby Dave Rigby made changes -
          Assignee Sriram Ganesan [ sriram ] Dave Rigby [ drigby ]
          drigby Dave Rigby made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          drigby Dave Rigby added a comment -

          Sriram Ganesan Assigned this back to me - I ended up implementing it as part of some local experiments myself.

          drigby Dave Rigby added a comment - Sriram Ganesan Assigned this back to me - I ended up implementing it as part of some local experiments myself.
          sriram Sriram Ganesan (Inactive) added a comment - Thanks Dave Rigby
          wayne Wayne Siu made changes -
          Link This issue blocks MB-25435 [ MB-25435 ]

          Build 5.1.0-1101 contains kv_engine commit 5d9bbe04f899375c28668c44ea566a9a162a8a51 with commit message:
          MB-25630: Include read-only KVStore stats in 'cbstats kvtimings'
          https://github.com/couchbase/kv_engine/commit/5d9bbe04f899375c28668c44ea566a9a162a8a51

          build-team Couchbase Build Team added a comment - Build 5.1.0-1101 contains kv_engine commit 5d9bbe04f899375c28668c44ea566a9a162a8a51 with commit message: MB-25630 : Include read-only KVStore stats in 'cbstats kvtimings' https://github.com/couchbase/kv_engine/commit/5d9bbe04f899375c28668c44ea566a9a162a8a51

          Build 4.6.4-4540 contains ep-engine commit 54e8ef67c306d1caffc05ee9614f7b0d996064f2 with commit message:
          MB-25630: Include read-only KVStore stats in 'cbstats kvtimings'
          https://github.com/couchbase/ep-engine/commit/54e8ef67c306d1caffc05ee9614f7b0d996064f2

          build-team Couchbase Build Team added a comment - Build 4.6.4-4540 contains ep-engine commit 54e8ef67c306d1caffc05ee9614f7b0d996064f2 with commit message: MB-25630 : Include read-only KVStore stats in 'cbstats kvtimings' https://github.com/couchbase/ep-engine/commit/54e8ef67c306d1caffc05ee9614f7b0d996064f2
          drigby Dave Rigby made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Resolved [ 5 ]
          drigby Dave Rigby made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          drigby Dave Rigby made changes -
          Fix Version/s 5.0.1 [ 14611 ]
          drigby Dave Rigby added a comment -

          Reopening to merge to 5.0.1.

          drigby Dave Rigby added a comment - Reopening to merge to 5.0.1.
          drigby Dave Rigby made changes -
          Link This issue blocks MB-25649 [ MB-25649 ]
          drigby Dave Rigby made changes -
          Resolution Fixed [ 1 ]
          Status Reopened [ 4 ] Resolved [ 5 ]

          Build 5.0.1-4687 contains kv_engine commit c35bd2581cbfeede31fd4c0c229ff1f8c16007e9 with commit message:
          MB-25630: Include read-only KVStore stats in 'cbstats kvtimings'
          https://github.com/couchbase/kv_engine/commit/c35bd2581cbfeede31fd4c0c229ff1f8c16007e9

          build-team Couchbase Build Team added a comment - Build 5.0.1-4687 contains kv_engine commit c35bd2581cbfeede31fd4c0c229ff1f8c16007e9 with commit message: MB-25630 : Include read-only KVStore stats in 'cbstats kvtimings' https://github.com/couchbase/kv_engine/commit/c35bd2581cbfeede31fd4c0c229ff1f8c16007e9

          Build 5.1.0-1235 contains kv_engine commit c35bd2581cbfeede31fd4c0c229ff1f8c16007e9 with commit message:
          MB-25630: Include read-only KVStore stats in 'cbstats kvtimings'
          https://github.com/couchbase/kv_engine/commit/c35bd2581cbfeede31fd4c0c229ff1f8c16007e9

          build-team Couchbase Build Team added a comment - Build 5.1.0-1235 contains kv_engine commit c35bd2581cbfeede31fd4c0c229ff1f8c16007e9 with commit message: MB-25630 : Include read-only KVStore stats in 'cbstats kvtimings' https://github.com/couchbase/kv_engine/commit/c35bd2581cbfeede31fd4c0c229ff1f8c16007e9
          bharath.gp Bharath G P added a comment -

          Validated on 4.6.4 build 4570.

          bharath.gp Bharath G P added a comment - Validated on 4.6.4 build 4570.
          bharath.gp Bharath G P made changes -
          VERIFICATION STEPS 1. Install latest couchbase server and setup the cluster
          2. Create bucket and load data to the bucket.
          3. Do read and writes on the data
          4. Run cbstats command for kvtimings. Validate that we see bot read-write(rw_) and read-only(ro_) stats in the output
          Status Resolved [ 5 ] Closed [ 6 ]

          Build 4.6.5-4707 contains testrunner commit 1198e41204ae5b466e669c1c04113ed14beef2cb with commit message:
          CBQE-4361 : Add testcases for MB-25630 (CBSE-4029)
          https://github.com/couchbase/testrunner/commit/1198e41204ae5b466e669c1c04113ed14beef2cb

          build-team Couchbase Build Team added a comment - Build 4.6.5-4707 contains testrunner commit 1198e41204ae5b466e669c1c04113ed14beef2cb with commit message: CBQE-4361 : Add testcases for MB-25630 (CBSE-4029) https://github.com/couchbase/testrunner/commit/1198e41204ae5b466e669c1c04113ed14beef2cb

          Build 5.0.2-5508 contains kv_engine commit 54e8ef67c306d1caffc05ee9614f7b0d996064f2 with commit message:
          MB-25630: Include read-only KVStore stats in 'cbstats kvtimings'
          https://github.com/couchbase/kv_engine/commit/54e8ef67c306d1caffc05ee9614f7b0d996064f2

          build-team Couchbase Build Team added a comment - Build 5.0.2-5508 contains kv_engine commit 54e8ef67c306d1caffc05ee9614f7b0d996064f2 with commit message: MB-25630 : Include read-only KVStore stats in 'cbstats kvtimings' https://github.com/couchbase/kv_engine/commit/54e8ef67c306d1caffc05ee9614f7b0d996064f2

          Build 5.5.0-1580 contains kv_engine commit 54e8ef67c306d1caffc05ee9614f7b0d996064f2 with commit message:
          MB-25630: Include read-only KVStore stats in 'cbstats kvtimings'
          https://github.com/couchbase/kv_engine/commit/54e8ef67c306d1caffc05ee9614f7b0d996064f2

          build-team Couchbase Build Team added a comment - Build 5.5.0-1580 contains kv_engine commit 54e8ef67c306d1caffc05ee9614f7b0d996064f2 with commit message: MB-25630 : Include read-only KVStore stats in 'cbstats kvtimings' https://github.com/couchbase/kv_engine/commit/54e8ef67c306d1caffc05ee9614f7b0d996064f2

          People

            drigby Dave Rigby
            drigby Dave Rigby
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              PagerDuty