Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-25630

Add read-only KVStore fsTimings to timing stats

    XMLWordPrintable

Details

    Description

      During investigation of slow background fetches on a customer environment, I found that while we record filesystem timings for both read-only and read-write KVStores, we only report the timings for read-write:

      void KVStore::addTimingStats(ADD_STAT add_stat, const void *c) {
       
          /* We don't support any timing stats for read-only instances
           * at this point.
           */
          if (isReadOnly()) {
              return;
          }
      

      To better assist in analysing read timings, we should also include the read-only instance in the stats (accessed via the kvtimings cbstats group).

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          drigby Dave Rigby created issue -
          drigby Dave Rigby made changes -
          Field Original Value New Value
          Link This issue depends on CBSE-4029 [ CBSE-4029 ]
          drigby Dave Rigby made changes -
          Assignee Dave Rigby [ drigby ] Sriram Ganesan [ sriram ]
          drigby Dave Rigby made changes -
          Link This issue depends on CBSE-4029 [ CBSE-4029 ]
          drigby Dave Rigby made changes -
          Link This issue relates to CBSE-4029 [ CBSE-4029 ]
          drigby Dave Rigby made changes -
          Rank Ranked higher
          drigby Dave Rigby made changes -
          Assignee Sriram Ganesan [ sriram ] Dave Rigby [ drigby ]
          drigby Dave Rigby made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          wayne Wayne Siu made changes -
          Link This issue blocks MB-25435 [ MB-25435 ]
          drigby Dave Rigby made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Resolved [ 5 ]
          drigby Dave Rigby made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          drigby Dave Rigby made changes -
          Fix Version/s 5.0.1 [ 14611 ]
          drigby Dave Rigby made changes -
          Link This issue blocks MB-25649 [ MB-25649 ]
          drigby Dave Rigby made changes -
          Resolution Fixed [ 1 ]
          Status Reopened [ 4 ] Resolved [ 5 ]
          bharath.gp Bharath G P made changes -
          VERIFICATION STEPS 1. Install latest couchbase server and setup the cluster
          2. Create bucket and load data to the bucket.
          3. Do read and writes on the data
          4. Run cbstats command for kvtimings. Validate that we see bot read-write(rw_) and read-only(ro_) stats in the output
          Status Resolved [ 5 ] Closed [ 6 ]

          People

            drigby Dave Rigby
            drigby Dave Rigby
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              PagerDuty