Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-25813

ifdef'd todo in subdoc code from 2015

    XMLWordPrintable

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • .master
    • 7.1.0
    • memcached

    Attachments

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

      Activity

        will.gardner Will Gardner (Inactive) created issue -
        will.gardner Will Gardner (Inactive) made changes -
        Field Original Value New Value
        Component/s memcached [ 11621 ]
        Component/s couchbase-bucket [ 10173 ]
        drigby Dave Rigby made changes -
        Assignee Dave Rigby [ drigby ]
        drigby Dave Rigby made changes -
        Rank Ranked lower

        Build couchbase-server-7.1.0-2209 contains kv_engine commit 422c4ae with commit message:
        MB-25813: Fixup test case and remove @todo

        build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-2209 contains kv_engine commit 422c4ae with commit message: MB-25813 : Fixup test case and remove @todo
        trond Trond Norbye made changes -
        Fix Version/s Neo [ 17615 ]
        trond Trond Norbye made changes -
        Assignee Trond Norbye [ trond ]
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        trond Trond Norbye made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        simon.dew Simon Dew made changes -
        Labels subdoc releasenote subdoc
        simon.dew Simon Dew made changes -
        Labels releasenote subdoc subdoc
        drigby Dave Rigby added a comment - - edited

        So there's no behaviour change in the server in Neo - attempting to insert a non-primitive type via ArrayAddUnique returns status code SubdocValueCantinsert; just as it did in prior versions.

        If the SDK is making changes to handle this scenario in a different way - it sounds like they are now checking for the argument type client-side and not sending it to the server if not primitive - then that is a behaviour change in the SDK and hence should be release-noted in the appropriate SDK release(s).

        drigby Dave Rigby added a comment - - edited So there's no behaviour change in the server in Neo - attempting to insert a non-primitive type via ArrayAddUnique returns status code SubdocValueCantinsert; just as it did in prior versions. If the SDK is making changes to handle this scenario in a different way - it sounds like they are now checking for the argument type client-side and not sending it to the server if not primitive - then that is a behaviour change in the SDK and hence should be release-noted in the appropriate SDK release(s).

        Thanks Dave Rigby that's helpful context, I may have misunderstood the ask from SDK team here, will refer back to them!

        hakim.cassimally Hakim Cassimally added a comment - Thanks Dave Rigby that's helpful context, I may have misunderstood the ask from SDK team here, will refer back to them!

        People

          trond Trond Norbye
          will.gardner Will Gardner (Inactive)
          Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

            Created:
            Updated:
            Resolved:

            Gerrit Reviews

              There are no open Gerrit changes

              PagerDuty