Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-26830

ItemPager/ExpiryPager/PagingVisitor refactor

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Major
    • None
    • master
    • couchbase-bucket

    Description

      A number of improvements could be made to these classes.

      • Consider creating two ItemPager tasks, one explicitly is triggered by an interval, the other is triggered by 'out-of-memory' conditions.
      • Consider structuring the tasks so that the ItemPager doesn't just end up scheduling a second task to do the visiting, consider integrating the visiting into the run loop (removing the shared_ptr<atomic_bool> available stuff).
      • Consider structuring the PagingVisitor to remove the need for the owner, perhaps EvictionVisitor and PagingVisitor which share a common parent class.
      • Likely more improvements too.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            Unassigned Unassigned
            jwalker Jim Walker
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty