Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-27197

[RocksDB] Do not read from disk to update the 'vbstate.highSeqno' in RocksDBKVStore::saveDocs

    XMLWordPrintable

Details

    • Task
    • Resolution: Done
    • Major
    • master
    • master
    • couchbase-bucket
    • None

    Description

      We currently do the following, but we can remove the read from disk and just set 'vbstate->highSeqno' to the last seqno we have jus written:

          // Check and update last seqno
          auto lastSeqno = readHighSeqnoFromDisk(*vbh);
          if (maxDBSeqno != lastSeqno) {
              logger.log(EXTENSION_LOG_WARNING,
                         "RocksDBKVStore::saveDocs: Seqno in db header (%" PRIu64
                         ") is not matched with what was persisted (%" PRIu64
                         ") for vb:%" PRIu16,
                         lastSeqno,
                         maxDBSeqno,
                         vbid);
          }
          vbstate->highSeqno = lastSeqno;
      

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            paolo.cocchi Paolo Cocchi
            paolo.cocchi Paolo Cocchi
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty