Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-27787

[N1QL] Major performance degradation of aggregation queries

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 5.5.0
    • 5.5.0
    • secondary-index
    • Build: 5.5.0-1751
      Cluster: iris
      OS: CentOS 7
      CPU: Data: E5-2630 v2 (24 vCPU), Query & Index: E5-2680 v3 (48 vCPU) Memory: Data & Query: 64GB, Index: 512GB Disk: Samsung Pro 850

    Description

      Changes caused the regression:

      changed projects : 
       
      	goproj/src/github.com/couchbase/indexing changed from 917a8ca928985dbfef6ba89e7ebf0ae781c71dca to master
      		[+] 560eec9 Merge remote-tracking branch 'couchbase/unstable' into HEAD
      		[+] 87e8384 MB-25162: Update Go targets to use Go 1.7.6
      		[+] c7aecc7 MB-26597 : GSI - Add Log Redaction Support - Part 2
      		[+] 0586f6e MB-23000 REST endpoint for Index stats ...
      		[+] f2f961e MB-26677 Upgrade path for XATTRs ...
       
      	query-ui changed from ca84b39b6e64fdf45beca714fb8a33d69ad82385 to master
      		[+] 0647dfb Improvements to handling of large documents in new doc editor.
      		[+] d3ff86a MB-27681 - Add an expand button to the JSON editor in the *new* document editor.
      

      http://172.23.120.24/builds/latestbuilds/couchbase-server/vulcan/1751/CHANGELOG

      CPU profile indicates major code path related to log redaction functionality (TagUD method).
      The regression most probably caused by this line:
      l.Debugf("ScanPipeline::computeGroupAggr %v", l.TagUD(s.p.aggrRes))
      (https://github.com/couchbase/indexing/commit/c7aecc78a40c4cf80a5f004cf98720ccbdc0cd6f#diff-e430d5eddad2ae791a8f3a4d11c6539bR193)
      when entire aggregation result is being passed to TagUD()

      CPU profile attached.

      Affected tests/queries:
      http://showfast.sc.couchbase.com/#/timeline/Linux/n1ql/count/MOI
      http://showfast.sc.couchbase.com/#/timeline/Linux/n1ql/tokens/all
      http://showfast.sc.couchbase.com/#/timeline/Linux/n1ql/Q5_Q7_thr/all

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            Sitaram just caught this today and Deep has diagnosed this as a regression after the build #1730.  Deep is doing that.  Thank you.

            keshav Keshav Murthy added a comment - Sitaram just caught this today and Deep has diagnosed this as a regression after the build #1730.  Deep is doing that.  Thank you.

            Hi Keshav Murthy,

            Alex confirmed that this issue was introduced by log redaction support in build 1751.

            pavelpaulau Pavel Paulau (Inactive) added a comment - Hi Keshav Murthy , Alex confirmed that this issue was introduced by log redaction support in build 1751.

            Thanks Pavel for capturing the profile. The log redaction part needs to be fixed.

            deepkaran.salooja Deepkaran Salooja added a comment - Thanks Pavel for capturing the profile. The log redaction part needs to be fixed.

            The below commit removes the optional logging statements. The overall issue with log redaction still needs to be fixed.

            http://review.couchbase.org/88530 MB-27787 Remove optional logging from scan pipeline

            deepkaran.salooja Deepkaran Salooja added a comment - The below commit removes the optional logging statements. The overall issue with log redaction still needs to be fixed. http://review.couchbase.org/88530 MB-27787 Remove optional logging from scan pipeline

            Build couchbase-server-5.5.0-1793 contains indexing commit bde41ae300105846f3628da96a6cd69d4153d683 with commit message:
            MB-27787 Remove optional logging from scan pipeline
            https://github.com/couchbase/indexing/commit/bde41ae300105846f3628da96a6cd69d4153d683

            build-team Couchbase Build Team added a comment - Build couchbase-server-5.5.0-1793 contains indexing commit bde41ae300105846f3628da96a6cd69d4153d683 with commit message: MB-27787 Remove optional logging from scan pipeline https://github.com/couchbase/indexing/commit/bde41ae300105846f3628da96a6cd69d4153d683

            People

              jeelan.poola Jeelan Poola
              oleksandr.gyryk Alex Gyryk (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty