Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-28159

Tighten serialised operator stop handling

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 5.5.0
    • 5.5.0
    • query
    • None
    • Untriaged
    • Yes

    Description

      Serialised operators rely on the producer to to close the channel and propagate a stop signal.
      If the producer does not do a close, the serialised operator will not notify that it has stopped.
      Augment the serializedSend() method to flag that the operator has stopped and do an early sendStop.
      Augment close method to only send a stop if processItem() did not fail.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          marco.greco Marco Greco added a comment -

          Fixed with change 89480

          marco.greco Marco Greco added a comment - Fixed with change 89480

          Build couchbase-server-5.5.0-1903 contains query commit 5472f553a724bc4c90621b285645ca71098109c4 with commit message:
          MB-28159 tighten serialised operator notifyStop
          https://github.com/couchbase/query/commit/5472f553a724bc4c90621b285645ca71098109c4

          build-team Couchbase Build Team added a comment - Build couchbase-server-5.5.0-1903 contains query commit 5472f553a724bc4c90621b285645ca71098109c4 with commit message: MB-28159 tighten serialised operator notifyStop https://github.com/couchbase/query/commit/5472f553a724bc4c90621b285645ca71098109c4
          ajay.bhullar Ajay Bhullar added a comment -

          How would I verify/ test this? 

          ajay.bhullar Ajay Bhullar added a comment - How would I verify/ test this? 
          marco.greco Marco Greco added a comment -

          Any test failing with a hang would suggest this is not fixed.

          marco.greco Marco Greco added a comment - Any test failing with a hang would suggest this is not fixed.
          ajay.bhullar Ajay Bhullar added a comment -

          Latest regression does not contain hangs, thus am closing. 

          ajay.bhullar Ajay Bhullar added a comment - Latest regression does not contain hangs, thus am closing. 

          People

            ajay.bhullar Ajay Bhullar
            marco.greco Marco Greco
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty