Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-28956

Int64 support in Spock breaks GSI upgrade

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 5.1.0
    • 5.5.0
    • secondary-index
    • None
    • Untriaged
    • Yes

    Description

      Int64 support was added as part of MB-20385. This changed the encoding format of the integers. This is a problem as after upgrade the storage is going to have a mix of old format and new format. 

      For scans, we convert the low/high key to storage format and do the comparison. This would only work with newly added storage keys. The old storage entries won't match due to different format.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            Re-opening this issue and marking it as resolved as this issue needs more detailed testing as outlined in the document.

            mihir.kamdar Mihir Kamdar (Inactive) added a comment - Re-opening this issue and marking it as resolved as this issue needs more detailed testing as outlined in the document.
            wayne Wayne Siu added a comment -

            Mihir Kamdar

            Please comment in the ticket when the fix is confirmed as the team will then backport the change to 5.1.1 

            wayne Wayne Siu added a comment - Mihir Kamdar Please comment in the ticket when the fix is confirmed as the team will then backport the change to 5.1.1 

            wording for the release notes for this fix: 

            ---------

            In release 5.0, we introduced the support for INT64 where GSI determines whether a given number will be encoded and stored as INT64 or FLOAT64 depends on its value. The underlying encoding format was changed to support this flexible encoding, but this scheme has caused incompatibility with the previous 4.x FLOAT64 encoding format. the problem has been fixed in release 5.1.1.

             

            1. When you upgrade from 4.x to 5.1.1, all existing indexes in 4.x continue to work as is
            2. If you have upgraded from release 4.x to 5.0.1 or 5.1.0, your indexes are likely to have the compatibility problem as mentioned above, in such case as we recommend that you upgrade to 5.1.1 in a timely manner. Please bnote that when you upgrade from 5.0.1 or 5.1.0 to 5.1.1, GSI will automatically upgrade the indexes for some upgrade scenarios but for others you have to drop and recreate of indexes post upgrade. Please see the 5.1.1 GSI upgrade matrix for the specifics

             -----------

            tai.tran Tai Tran (Inactive) added a comment - wording for the release notes for this fix:  --------- In release 5.0, we introduced the support for INT64 where GSI determines whether a given number will be encoded and stored as INT64 or FLOAT64 depends on its value. The underlying encoding format was changed to support this flexible encoding, but this scheme has caused incompatibility with the previous 4.x FLOAT64 encoding format. the problem has been fixed in release 5.1.1.   When you upgrade from 4.x to 5.1.1, all existing indexes in 4.x continue to work as is If you have upgraded from release 4.x to 5.0.1 or 5.1.0, your indexes are likely to have the compatibility problem as mentioned above, in such case as we recommend that you upgrade to 5.1.1 in a timely manner. Please bnote that when you upgrade from 5.0.1 or 5.1.0 to 5.1.1, GSI will automatically upgrade the indexes for some upgrade scenarios but for others you have to drop and recreate of indexes post upgrade. Please see the 5.1.1 GSI upgrade matrix for the specifics  -----------

            Verified on vulcan build. Job is running on weekly basis. Closing

            prasanna.gholap Prasanna Gholap [X] (Inactive) added a comment - Verified on vulcan build. Job is running on weekly basis. Closing

            Reopening and keeping it in resolved state since our upgrade automation tests are blocked because of MB-24464

            prasanna.gholap Prasanna Gholap [X] (Inactive) added a comment - Reopening and keeping it in resolved state since our upgrade automation tests are blocked because of  MB-24464

            People

              prasanna.gholap Prasanna Gholap [X] (Inactive)
              deepkaran.salooja Deepkaran Salooja
              Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty