Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-33153

Bucket::topkeys cache line contention

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 6.5.0
    • 6.5.0
    • memcached
    • Untriaged
    • Unknown

    Description

      A good description of this issue can be found here https://issues.couchbase.com/browse/MB-32107?focusedCommentId=317289&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-317289.

      Unsure if this will lead to performance gains, however a reduction of cache contention certainly isn't a bad thing and the changes is relatively trivial.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          Ascending order - Click to sort in descending order
          ben.huddleston Ben Huddleston created issue -
          ben.huddleston Ben Huddleston made changes -
          Field Original Value New Value
          Component/s memcached [ 11621 ]
          build-team Couchbase Build Team added a comment -

          Build couchbase-server-6.5.0-2602 contains kv_engine commit 4d81986 with commit message:
          MB-33153: Move topkeys unique ptr to reduce cache contention

          build-team Couchbase Build Team added a comment - Build couchbase-server-6.5.0-2602 contains kv_engine commit 4d81986 with commit message: MB-33153 : Move topkeys unique ptr to reduce cache contention
          ben.huddleston Ben Huddleston added a comment -

          Used perf c2c to profile build 2602, no evidence of the previously contentious cache line.

          ben.huddleston Ben Huddleston added a comment - Used perf c2c to profile build 2602, no evidence of the previously contentious cache line.
          ben.huddleston Ben Huddleston made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          ben.huddleston Ben Huddleston made changes -
          Actual End 2019-03-13 06:24 (issue has been resolved)
          ben.huddleston Ben Huddleston made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

          People

            ben.huddleston Ben Huddleston
            ben.huddleston Ben Huddleston
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty