Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-33813

Memcached returns NOT_STORED to client after trying to perform arithmetic operation

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • master, 6.5.0, 5.5.0, 5.5.3
    • 6.5.0
    • memcached
    • Untriaged
    • Yes

    Description

      There is a race condition in ArithmeticCommandContext where a SET operation is performed between the ArithmeticCommandContext::getItem() and ArithmeticCommandContext::storeNewItem(), causing the call to bucket_store() to return ENGINE_NOT_STORED. Currently we just return this error to the memcached client however, this brakes the behaviour of this interface that existed before the refactoring of our arithmetic operations (see v4.5.0). Thus, we should resolve this race condition by trying to re-perform the arithmetic operation by resetting the ArithmeticCommandContext state machine.

      Attachments

        Issue Links

          backports to

          Bug - A problem which impairs or prevents the functions of the product. MB-33852 [5.5.4] - Memcached returns NOT_STORED to client after trying to perform arithmetic operation

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MB-33854 [6.0.2] - Memcached returns NOT_STORED to client after trying to perform arithmetic operation

          • Major - Major loss of function.
          • Closed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            Ascending order - Click to sort in descending order
            richard.demellow Richard deMellow created issue -
            richard.demellow Richard deMellow made changes -
            Field Original Value New Value
            Assignee Trond Norbye [ trond ] Richard deMellow [ richard.demellow ]
            richard.demellow Richard deMellow made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            richard.demellow Richard deMellow made changes -
            Actual Start 2019-04-16 08:26 (issue has been started)
            richard.demellow Richard deMellow made changes -
            Link This issue relates to CBSE-6638 [ CBSE-6638 ]
            raju Raju Suravarjjala made changes -
            Fix Version/s Mad-Hatter [ 15037 ]
            richard.demellow Richard deMellow made changes -
            Affects Version/s 5.5.0 [ 14610 ]
            dfinlay Dave Finlay made changes -
            Link This issue backports to MB-33852 [ MB-33852 ]
            wayne Wayne Siu made changes -
            Link This issue backports to MB-33854 [ MB-33854 ]
            build-team Couchbase Build Team added a comment -

            Build couchbase-server-5.5.4-4336 contains kv_engine commit 454186c with commit message:
            MB-33852: Fix NOT_STORED being returned from arithmetic op

            build-team Couchbase Build Team added a comment - Build couchbase-server-5.5.4-4336 contains kv_engine commit 454186c with commit message: MB-33852 : Fix NOT_STORED being returned from arithmetic op
            richard.demellow Richard deMellow made changes -
            Fix Version/s 6.0.2 [ 15919 ]
            Fix Version/s 5.5.3 [ 15520 ]
            richard.demellow Richard deMellow made changes -
            Fix Version/s 5.5.4 [ 16003 ]
            Fix Version/s 5.5.3 [ 15520 ]
            build-team Couchbase Build Team added a comment -

            Build couchbase-server-6.0.2-2365 contains kv_engine commit f4395e1 with commit message:
            MB-33854: Merge remote-tracking branch 'couchbase/vulcan' into alice

            build-team Couchbase Build Team added a comment - Build couchbase-server-6.0.2-2365 contains kv_engine commit f4395e1 with commit message: MB-33854 : Merge remote-tracking branch 'couchbase/vulcan' into alice
            build-team Couchbase Build Team added a comment -

            Build couchbase-server-6.0.2-2365 contains kv_engine commit 454186c with commit message:
            MB-33852: Fix NOT_STORED being returned from arithmetic op

            build-team Couchbase Build Team added a comment - Build couchbase-server-6.0.2-2365 contains kv_engine commit 454186c with commit message: MB-33852 : Fix NOT_STORED being returned from arithmetic op
            wayne Wayne Siu made changes -
            Fix Version/s 6.0.2 [ 15919 ]
            Fix Version/s 5.5.4 [ 16003 ]
            drigby Dave Rigby made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]
            drigby Dave Rigby made changes -
            Actual End 2019-04-23 03:56 (issue has been resolved)
            build-team Couchbase Build Team added a comment -

            Build couchbase-server-6.5.0-3032 contains kv_engine commit f4395e1 with commit message:
            MB-33854: Merge remote-tracking branch 'couchbase/vulcan' into alice

            build-team Couchbase Build Team added a comment - Build couchbase-server-6.5.0-3032 contains kv_engine commit f4395e1 with commit message: MB-33854 : Merge remote-tracking branch 'couchbase/vulcan' into alice
            build-team Couchbase Build Team added a comment -

            Build couchbase-server-6.5.0-3032 contains kv_engine commit 454186c with commit message:
            MB-33852: Fix NOT_STORED being returned from arithmetic op

            build-team Couchbase Build Team added a comment - Build couchbase-server-6.5.0-3032 contains kv_engine commit 454186c with commit message: MB-33852 : Fix NOT_STORED being returned from arithmetic op
            ritam.sharma Ritam Sharma made changes -
            VERIFICATION STEPS Closed based on unit tests attached with defect.
            Status Resolved [ 5 ] Closed [ 6 ]

            People

              richard.demellow Richard deMellow
              richard.demellow Richard deMellow
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty