Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
master, 6.5.0, 5.5.0, 5.5.3
-
Untriaged
-
Yes
Description
[Cloned this from MB-33813 to track merging a fix for this issue to 5.5.4.]
There is a race condition in ArithmeticCommandContext where a SET operation is performed between the ArithmeticCommandContext::getItem() and ArithmeticCommandContext::storeNewItem(), causing the call to bucket_store() to return ENGINE_NOT_STORED. Currently we just return this error to the memcached client however, this brakes the behaviour of this interface that existed before the refactoring of our arithmetic operations (see v4.5.0). Thus, we should resolve this race condition by trying to re-perform the arithmetic operation by resetting the ArithmeticCommandContext state machine.
Attachments
Issue Links
- is a backport of
-
-
- Closed
-
| For Gerrit Dashboard: MB-33852 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 107944,4 | MB-33852: Fix NOT_STORED being returned from arithmetic op | vulcan | kv_engine | Status: MERGED | +2 | +1 |
| 108004,1 | MB-33854: Merge remote-tracking branch 'couchbase/vulcan' into alice | alice | kv_engine | Status: MERGED | +2 | +1 |
| 108012,2 | Merge remote-tracking branch 'couchbase/alice' | master | kv_engine | Status: MERGED | +2 | +1 |
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
There is a race condition in {{ArithmeticCommandContext}} where a {{SET}} operation is performed between the {{ArithmeticCommandContext::getItem()}} and {{ArithmeticCommandContext::storeNewItem()}}, causing the call to {{bucket_store()}} to return {{ENGINE_NOT_STORED}}. Currently we just return this error to the memcached client however, this brakes the behaviour of this interface that existed before the refactoring of our arithmetic operations (see v4.5.0). Thus, we should resolve this race condition by trying to re-perform the arithmetic operation by resetting the {{ArithmeticCommandContext}} state machine.
|
[Cloned this from There is a race condition in {{ArithmeticCommandContext}} where a {{SET}} operation is performed between the {{ArithmeticCommandContext::getItem()}} and {{ArithmeticCommandContext::storeNewItem()}}, causing the call to {{bucket_store()}} to return {{ENGINE_NOT_STORED}}. Currently we just return this error to the memcached client however, this brakes the behaviour of this interface that existed before the refactoring of our arithmetic operations (see v4.5.0). Thus, we should resolve this race condition by trying to re-perform the arithmetic operation by resetting the {{ArithmeticCommandContext}} state machine. |
| Link | This issue blocks MB-32627 [ MB-32627 ] |
| Fix Version/s | 5.5.4 [ 16003 ] | |
| Fix Version/s | Mad-Hatter [ 15037 ] |
Marking resolved as the fix has been merged into couchbase/vulcan at commit 454186c6c9155e5fed62e0ce5d5082c7ed3a1e48 and has been built in coucbase-server-5.5.4-4336
| Resolution | Fixed [ 1 ] | |
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Actual End | 2019-04-18 05:01 (issue has been resolved) |
| Link | This issue relates to CBSE-6638 [ CBSE-6638 ] |
Build couchbase-server-6.0.2-2365 contains kv_engine commit f4395e1 with commit message:
MB-33854: Merge remote-tracking branch 'couchbase/vulcan' into alice
Build couchbase-server-6.0.2-2365 contains kv_engine commit f4395e1 with commit message:
MB-33854: Merge remote-tracking branch 'couchbase/vulcan' into alice
Build couchbase-server-6.0.2-2365 contains kv_engine commit 454186c with commit message:
MB-33852: Fix NOT_STORED being returned from arithmetic op
| Labels | memcached | memcached releasenote |
Build couchbase-server-6.5.0-3032 contains kv_engine commit cb3e3e7 with commit message:
Merge remote-tracking branch 'couchbase/alice'
Build couchbase-server-6.5.0-3032 contains kv_engine commit f4395e1 with commit message:
MB-33854: Merge remote-tracking branch 'couchbase/vulcan' into alice
Build couchbase-server-6.5.0-3032 contains kv_engine commit f4395e1 with commit message:
MB-33854: Merge remote-tracking branch 'couchbase/vulcan' into alice
Build couchbase-server-6.5.0-3032 contains kv_engine commit 454186c with commit message:
MB-33852: Fix NOT_STORED being returned from arithmetic op
regression looks good against 5.5.4 - closing this ticket
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Build couchbase-server-5.5.4-4336 contains kv_engine commit 454186c with commit message:
MB-33852: Fix NOT_STORED being returned from arithmetic op