Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-34189

"Dynamic" SET_PARAM options in ep-engine are not all modifiable via epctl

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 6.5.0, 5.1.3, 6.0.1, 5.5.4
    • 6.5.0
    • couchbase-bucket
    • Untriaged
    • Unknown
    • KV-Engine MH 2nd Beta

    Description

      In ep-engine the SET_PARAM implementation (EventuallyPersistentEngine::setParam) is a hand-written code to check for each dynamically configurable config parameter.

      As such, it is easy to omit a code for particular dynamic config param and not be able to change it via epctl.

      For example, flusher_batch_split_trigger is a dynamic config param and the flusher itself can handle it changing dynamically, however it has been omitted from the SET_PARAM(flush) handler - EventuallyPersistentEngine::setFlushParam and hence cannot be modified on the fly. I expect an audit of the config parameters will identify more...

      We should:

      1. Add tests which verify that every dynamic config parameter in configuration.json can indeed to changed via SET_PARAM, and/or
      2. Modify EventuallyPersistentEngine::setParam and related functions to be data-driven / auto-generated from configuration.json, enforcing that all params marked as dynamic are indeed dynamically-modifiable.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          Build couchbase-server-6.5.0-4448 contains kv_engine commit 1c8db7e with commit message:
          MB-34189: Audit configuration.json for non-dynamic params

          build-team Couchbase Build Team added a comment - Build couchbase-server-6.5.0-4448 contains kv_engine commit 1c8db7e with commit message: MB-34189 : Audit configuration.json for non-dynamic params

          Build couchbase-server-6.5.0-4451 contains kv_engine commit 642bc8b with commit message:
          MB-34189: Allow connection_manager_interval to be dynamically changed

          build-team Couchbase Build Team added a comment - Build couchbase-server-6.5.0-4451 contains kv_engine commit 642bc8b with commit message: MB-34189 : Allow connection_manager_interval to be dynamically changed

          Build couchbase-server-7.0.0-1001 contains kv_engine commit 642bc8b with commit message:
          MB-34189: Allow connection_manager_interval to be dynamically changed

          build-team Couchbase Build Team added a comment - Build couchbase-server-7.0.0-1001 contains kv_engine commit 642bc8b with commit message: MB-34189 : Allow connection_manager_interval to be dynamically changed

          Build couchbase-server-6.5.0-4477 contains kv_engine commit dc3f4f5 with commit message:
          MB-34189: Add missing handlers for dynamic config params

          build-team Couchbase Build Team added a comment - Build couchbase-server-6.5.0-4477 contains kv_engine commit dc3f4f5 with commit message: MB-34189 : Add missing handlers for dynamic config params

          Build couchbase-server-6.5.0-4477 contains kv_engine commit c822803 with commit message:
          MB-34189: Allow durability_timeout_task_interval to be changed dynamically

          build-team Couchbase Build Team added a comment - Build couchbase-server-6.5.0-4477 contains kv_engine commit c822803 with commit message: MB-34189 : Allow durability_timeout_task_interval to be changed dynamically

          Build couchbase-server-7.0.0-1002 contains kv_engine commit dc3f4f5 with commit message:
          MB-34189: Add missing handlers for dynamic config params

          build-team Couchbase Build Team added a comment - Build couchbase-server-7.0.0-1002 contains kv_engine commit dc3f4f5 with commit message: MB-34189 : Add missing handlers for dynamic config params

          Build couchbase-server-7.0.0-1002 contains kv_engine commit c822803 with commit message:
          MB-34189: Allow durability_timeout_task_interval to be changed dynamically

          build-team Couchbase Build Team added a comment - Build couchbase-server-7.0.0-1002 contains kv_engine commit c822803 with commit message: MB-34189 : Allow durability_timeout_task_interval to be changed dynamically

          Closing since the unit_tests are passing.

          ashwin.govindarajulu Ashwin Govindarajulu added a comment - Closing since the unit_tests are passing.

          People

            drigby Dave Rigby
            drigby Dave Rigby
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                PagerDuty