Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-34280

Memcached should disallow DCP connections with names greater than 200 characters (was: ns_server connections may be terminated if a client uses a long DCP_OPEN.name)

    XMLWordPrintable

Details

    • KV-Engine MH 2nd Beta

    Description

      Summary

      If a DCP client uses a long (exact length TBD) name when connecting, it can result in
      STATS calls (for example performed by ns_server to monitor rebalance) to fail:

       462445 2019-05-11T08:18:28.525392+00:00 WARNING 143: exception occurred in runloop during packet execution. Cookie info: {"packet":{"magic":"ClientRequest","opcode":"STAT","keylen":3,"extlen":0,"datatype":"raw","vbucket":0,"bodylen":3,"opaque":"0x0","cas":0},"connection":"[ 127.0.0.1:48735 - 127.0.0.1:11209 (<ud>@ns_server</ud>) ]"} - closing connection: Response::setKeylen: key cannot exceed 1 byte

      Details

      Looks like problem is here - we cap the response keyLen to 1 byte for all response types, not just "Response with flex-framing extras" (0x18):

          void setKeylen(uint16_t value) {
      		 
              if (value > 0xff) {
      		 
                  throw std::invalid_argument(
      		 
                          "Response::setKeylen: key cannot exceed 1 byte");
      		 
              }
      		 
              keylen = uint8_t(value);
      		 
          }

      This change was introduced via: http://review.couchbase.org/#/c/86393/

      See https://github.com/couchbase/kv_engine/blob/master/docs/BinaryProtocol.md#response-header - it should be permitted to return keys up to 65,535 bytes long for "regular" response packets (0x81).

      Attachments

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. MB-35881 ns_server should generate DCP connection names that are no longer than allowed by memcached

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MB-37246 Ensure Views does not generate DCP connection names that are no longer than allowed by memcached

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MB-37283 Ensure XDCR does not generate DCP connection names that are no longer than allowed by memcached

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MB-49271 Backport MB-35881 to 6.6.4

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MB-37244 Ensure 2i does not generate DCP connection names that are no longer than allowed by memcached

          • Major - Major loss of function.
          • Open

          Task - A task that needs to be done. CBES-145 Ensure ElastricSearch Connector does not generate DCP connection names that are no longer than allowed by memcached

          • Major - Major loss of function.
          • Resolved

          Task - A task that needs to be done. JDCP-136 Ensure java-DCP-client does not generate DCP connection names that are no longer than allowed by memcached

          • Major - Major loss of function.
          • Resolved

          Task - A task that needs to be done. KAFKAC-160 Ensure Kafka Connector does not generate DCP connection names that are no longer than allowed by memcached

          • Major - Major loss of function.
          • Resolved

          Task - A task that needs to be done. CBG-626 Ensure Sync-Gateway does not generate DCP connection names that are no longer than allowed by memcached

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MB-37241 Ensure FTS does not generate DCP connection names that are no longer than allowed by memcached

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MB-37242 Ensure Backup does not generate DCP connection names that are no longer than allowed by memcached

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MB-37243 Ensure Query does not generate DCP connection names that are no longer than allowed by memcached

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MB-37245 Ensure Eventing does not generate DCP connection names that are no longer than allowed by memcached

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. MB-35882 The Memcached STATS "dcp" command should have a mode that only retrieves stats on connections owned by the user

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MB-42968 Eventing Enabled Cluster Fails to Recover

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MB-51513 Upgrades can fail due to the 200 character limit for DCP connections

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. DOC-9381 names used for DCP connections must not be longer than 200 characters

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. JDCP-137 Increase connection name limit from 148 bytes to 200 bytes

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. CMOS-154 Add check for DCP names > 200 chars (MB-34280)

          • Major - Major loss of function.
          • Done
          For Gerrit Dashboard: MB-34280
          # Subject Branch Project Status CR V
          109497,4 MB-34280: Allow long keys in (normal) return packets alice kv_engine Status: ABANDONED -1 +1
          114481,8 MB-34280: Set max DCP name to 200 characters master kv_engine Status: MERGED +2 +1
          119330,2 JDCP-137 Increase connection name limit from 148 bytes to 200 bytes master java-dcp-client Status: MERGED +2 +1
          164809,3 MB-34280: Set max DCP name to 200 characters mad-hatter kv_engine Status: MERGED +2 +1
          166408,1 Merge remote-tracking branch 'couchbase/mad-hatter' cheshire-cat kv_engine Status: MERGED +2 +1
          166749,1 Merge commit mad-hatter 'b5fa131c0' into couchbase/cheshire-cat cheshire-cat kv_engine Status: ABANDONED +2 -1
          167587,1 Merge remote-tracking branch 'couchbase/cheshire-cat' into 'couchbase/master' master kv_engine Status: MERGED +2 +1
          169962,2 K8S-2534: Warn users from using long-names master couchbase-operator Status: ABANDONED -2 0
          172119,1 MB-51513: Revert "MB-34280: Set max DCP name to 200 characters" master kv_engine Status: ABANDONED -1 -1
          172485,2 MB-51513: Revert "MB-34280: Set max DCP name to 200 characters" cheshire-cat kv_engine Status: MERGED +2 +1
          172495,1 MB-51513: Merge branch 'couchbase/cheshire-cat' into 'couchbase/neo' neo kv_engine Status: MERGED +2 +1
          172599,1 Merge branch 'neo' master kv_engine Status: ABANDONED 0 -1
          172641,1 Merge branch 'neo' into master master kv_engine Status: MERGED +2 +1

          Activity

            People

              ritam.sharma Ritam Sharma
              drigby Dave Rigby
              Votes:
              0 Vote for this issue
              Watchers:
              16 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                PagerDuty