Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-35846

The ability to create backups using the ForestDB storage format should be removed

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Done
    • 6.6.0
    • 6.6.0
    • tools

    Description

      ForestDB has been marked as depreciated for a while now and will no longer be supported by cbbackupmgr. For this reason (and several others) collection aware backup restore will only be supported for SQLite. We do however, still need to retain the ability to read from (and therefore merge) users existing backups which use the ForestDB format.

      How will we achieve this change?

      The storage format we use must conform to the 'BackupFile' interface; this constricts us to having only read write storage formats, therefore, the 'BackupFile' interface will be replaced with the 'BackupFileReader' and 'BackupFileWriter' interfaces. This will then mean a large portion of the ForestDB codebase can be stripped away.

      What  are the benefits of this change?

      1) We no longer have to support two different backup storage formats (collection aware/unaware).

      2) When it comes to writing stats (on 'DataBackup' Close) we can do so in a collection aware fashion without having to support writing collection unaware stats files (we should still be able to read them for backwards compatible use of the info/list commands).

      What are the consequences of this change?

      1) Users will no longer be able to force the creation of ForestDB backups using the hidden 'storage' flag.

       

      Attachments

        For Gerrit Dashboard: MB-35846
        # Subject Branch Project Status CR V

        Activity

          james.lee James Lee created issue -
          james.lee James Lee made changes -
          Field Original Value New Value
          Epic Link MB-31582 [ 91904 ]
          james.lee James Lee made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          james.lee James Lee made changes -
          Issue Type Bug [ 1 ] Improvement [ 4 ]
          james.lee James Lee made changes -
          Resolution Done [ 6 ]
          Status In Progress [ 3 ] Resolved [ 5 ]
          pvarley Patrick Varley made changes -
          Affects Version/s Cheshire-Cat [ 15915 ]
          Affects Version/s master [ 13407 ]
          pvarley Patrick Varley made changes -
          Fix Version/s Cheshire-Cat [ 15915 ]
          Fix Version/s master [ 13407 ]
          pvarley Patrick Varley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

          Build couchbase-server-6.6.0-7625 contains backup commit ce7cf28 with commit message:
          MB-35846 Removed support for creating ForestDB backups

          build-team Couchbase Build Team added a comment - Build couchbase-server-6.6.0-7625 contains backup commit ce7cf28 with commit message: MB-35846 Removed support for creating ForestDB backups
          owend Daniel Owen made changes -
          Affects Version/s 6.6.0 [ 16787 ]
          Affects Version/s Cheshire-Cat [ 15915 ]
          owend Daniel Owen made changes -
          Fix Version/s 6.6.0 [ 16787 ]
          Fix Version/s Cheshire-Cat [ 15915 ]
          owend Daniel Owen made changes -
          Labels approved-for-6.6.0
          pvarley Patrick Varley made changes -
          Link This issue blocks MB-38724 [ MB-38724 ]

          People

            james.lee James Lee
            james.lee James Lee
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty